-
Notifications
You must be signed in to change notification settings - Fork 630
Update plugins.calcite.enabled setting default #11435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: kolchfa-aws <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@LantaoJin Could you review this PR and answer the following questions:
|
No. Enabling Calcite by default means we expected PPL queries are running integrated with Calcite engine by default since 3.3.0.
As said above, we expected all queries running integrated with Calcite engine. Yes, it can be disabled by setting
Did we document all other configurations in |
We should document all configurations on the documentation website. The teams developing the feature should submit PRs to update the documentation with every release. Thank you. |
natebower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kolchfa-aws <[email protected]> (cherry picked from commit e0583a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Arya Soni <[email protected]>
Closes #11408
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.