Skip to content

Conversation

@kolchfa-aws
Copy link
Collaborator

Closes #11408

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator Author

@LantaoJin Could you review this PR and answer the following questions:

  • Is the feature still experimental?
  • Is the plugins.calcite.enabled setting valid and can the users set it to false to disable it? I don't see the setting here.
  • Do we need to document the plugins.calcite.all_join_types.allowed setting?

@kolchfa-aws kolchfa-aws added backport 3.3 Tech review PR: Tech review in progress labels Oct 28, 2025
@LantaoJin
Copy link
Member

LantaoJin commented Oct 29, 2025

  • Is the feature still experimental?

No. Enabling Calcite by default means we expected PPL queries are running integrated with Calcite engine by default since 3.3.0.

  • Is the plugins.calcite.enabled setting valid and can the users set it to false to disable it? I don't see the setting here.

As said above, we expected all queries running integrated with Calcite engine. Yes, it can be disabled by setting plugins.calcite.enabled=false. But I think it is unnecessary to callout.

Did we document all other configurations in documentation-website? Yes if always update new configurations.

@kolchfa-aws
Copy link
Collaborator Author

kolchfa-aws commented Oct 29, 2025

Did we document all other configurations in documentation-website? Yes if always update new configurations.

We should document all configurations on the documentation website. The teams developing the feature should submit PRs to update the documentation with every release. Thank you.

@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Tech review PR: Tech review in progress labels Oct 29, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the Editorial review PR: Editorial review in progress label Oct 29, 2025
@natebower natebower merged commit e0583a0 into main Oct 29, 2025
11 checks passed
@natebower natebower deleted the kolchfa-aws-patch-5 branch October 29, 2025 19:10
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 29, 2025
Signed-off-by: kolchfa-aws <[email protected]>
(cherry picked from commit e0583a0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
aryasoni98 pushed a commit to aryasoni98/documentation-website that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] plugins.ppl.enabled default setting is wrong

3 participants