Skip to content

Conversation

@Arraying
Copy link
Member

@Arraying Arraying commented Nov 25, 2025

This adds the tests to the problemlist.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8372509: [lworld] ProblemList compiler/codegen/TestRedundantLea.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1760/head:pull/1760
$ git checkout pull/1760

Update a local copy of the PR:
$ git checkout pull/1760
$ git pull https://git.openjdk.org/valhalla.git pull/1760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1760

View PR using the GUI difftool:
$ git pr show -t 1760

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1760.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2025

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372509: [lworld] ProblemList compiler/codegen/TestRedundantLea.java

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MrSimms) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8372509 8372509: [lworld] Problemlist compiler/codegen/TestRedundantLea.java Nov 25, 2025
Copy link
Member

@MrSimms MrSimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, testing "ProblemList" in the bug labels

@Arraying Arraying changed the title 8372509: [lworld] Problemlist compiler/codegen/TestRedundantLea.java 8372509 Nov 25, 2025
@openjdk openjdk bot changed the title 8372509 8372509: [lworld] ProblemList compiler/codegen/TestRedundantLea.java Nov 25, 2025
@Arraying
Copy link
Member Author

Thanks for the review @MrSimms.

/integrate

@Arraying Arraying marked this pull request as ready for review November 25, 2025 14:35
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 25, 2025
@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@Arraying
Your change (at version d9f3765) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Nov 25, 2025

Webrevs

@openjdk openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Nov 25, 2025
@MrSimms
Copy link
Member

MrSimms commented Nov 28, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

Going to push as commit 8b05c16.
Since your change was applied there have been 3 commits pushed to the lworld branch:

  • 1144cb4: 8372038: [lworld] Update ExplodedImage to use preview mode correctly
  • 0a86ffe: 8364107: [lworld] Revise memory limit in compiler/startup/StartupOutput.java
  • 23f0b1e: 8372529: [lworld] sources/TestIncludesAreSorted.java failures caused by JDK-8371915

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2025
@openjdk openjdk bot closed this Nov 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@MrSimms @Arraying Pushed as commit 8b05c16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants