Skip to content

Conversation

kirill-shirokov
Copy link

@kirill-shirokov kirill-shirokov commented Sep 4, 2025

The new tests cover only NPE scenarios.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8366522: CodeSource.getCodeSigners() throws NPE within empty certs (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27105/head:pull/27105
$ git checkout pull/27105

Update a local copy of the PR:
$ git checkout pull/27105
$ git pull https://git.openjdk.org/jdk.git pull/27105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27105

View PR using the GUI difftool:
$ git pr show -t 27105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27105.diff

@kirill-shirokov
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 4, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2025

Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 4, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@kirill-shirokov The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Copy link
Member

@myankelev myankelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 minor comment scratch that, I'm confused :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status security [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants