Skip to content

Enable Go modules as a default #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexellis opened this issue Nov 3, 2021 · 3 comments · Fixed by #63
Closed

Enable Go modules as a default #62

alexellis opened this issue Nov 3, 2021 · 3 comments · Fixed by #63
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alexellis
Copy link
Member

alexellis commented Nov 3, 2021

Description

Enable Go modules as a default

Update the templates to use GO111MODULE=on as a default

Then clarify in the docs or the README here how to turn it off, for those who need to vendor private code.

Testing

Test end to end to show that the build arg to turn off modules still works

Show output that also shows the default is working without additional settings.

@alexellis
Copy link
Member Author

/add label: good first issue, help wanted

@derek derek bot added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 3, 2021
@cpanato
Copy link
Contributor

cpanato commented Nov 3, 2021

i will work on that, expected to have a pr by the end of the week

@alexellis
Copy link
Member Author

Thanks Carlos

@cpanato cpanato mentioned this issue Nov 3, 2021
4 tasks
@alexellis alexellis moved this to Todo in OpenFaaS - Dec 2021 Nov 4, 2021
@alexellis alexellis moved this from Todo to In Progress in OpenFaaS - Dec 2021 Nov 4, 2021
Repository owner moved this from In Progress to Done in OpenFaaS - Dec 2021 Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

2 participants