Skip to content

Commit c58ee11

Browse files
committed
fix: check for nullable or not required
1 parent 849be6e commit c58ee11

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

openapi_python_client/parser/properties.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def get_imports(self, *, prefix: str) -> Set[str]:
6363
Args:
6464
prefix: A prefix to put before any relative (local) module names.
6565
"""
66-
if not self.required:
66+
if self.nullable or not self.required:
6767
return {"from typing import Optional"}
6868
return set()
6969

openapi_python_client/templates/model.pyi

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ class {{ model.reference.class_name }}:
3434
@staticmethod
3535
def from_dict(d: Dict[str, Any]) -> {{ model.reference.class_name }}:
3636
{% for property in model.required_properties + model.optional_properties %}
37-
{% if property.required %}
38-
{% set property_source = 'd["' + property.name + '"]' %}
39-
{% else %}
37+
{% if property.nullable or not property.required %}
4038
{% set property_source = 'd.get("' + property.name + '")' %}
39+
{% else %}
40+
{% set property_source = 'd["' + property.name + '"]' %}
4141
{% endif %}
4242
{% if property.template %}
4343
{% from "property_templates/" + property.template import construct %}

0 commit comments

Comments
 (0)