add test for existing parameter has a conflicting PythonIdentifier after renaming

Author: mtovts

tests/test_parser/test_openapi.py

@@ -534,11 +534,13 @@ def test_validation_error_when_location_not_supported(self, mocker):
         with pytest.raises(pydantic.ValidationError):
             oai.Parameter(name="test", required=True, param_schema=mocker.MagicMock(), param_in="error_location")
 
-    def test__add_parameters_with_location_postfix_conflict(self, mocker):
+    def test__add_parameters_with_location_postfix_conflict1(self, mocker):
+        """Checks when the PythonIdentifier of new parameter already used"""
         from openapi_python_client.parser.openapi import Endpoint
         from openapi_python_client.parser.properties import Property
 
         endpoint = self.make_endpoint()
+
         path_prop_name_conflicted = "prop_name_path"
         path_prop_conflicted = mocker.MagicMock(autospec=Property)
         path_prop_conflicted_import = mocker.MagicMock()
@@ -592,6 +594,52 @@ def test__add_parameters_with_location_postfix_conflict(self, mocker):
         assert isinstance(result, ParseError)
         assert result.detail == "Parameters with same Python identifier `prop_name_path` detected"
 
+    def test__add_parameters_with_location_postfix_conflict2(self, mocker):
+        """Checks when an existing parameter has a conflicting PythonIdentifier after renaming."""
+        from openapi_python_client.parser.openapi import Endpoint
+        from openapi_python_client.parser.properties import Property
+
+        endpoint = self.make_endpoint()
+        path_prop_conflicted = Property(
+            name="prop_name_path", required=False, nullable=False, default=None, python_name="prop_name_path"
+        )
+        path_prop = Property(name="prop_name", required=False, nullable=False, default=None, python_name="prop_name")
+        query_prop = Property(name="prop_name", required=False, nullable=False, default=None, python_name="prop_name")
+        schemas_1 = mocker.MagicMock()
+        schemas_2 = mocker.MagicMock()
+        schemas_3 = mocker.MagicMock()
+        property_from_data = mocker.patch(
+            f"{MODULE_NAME}.property_from_data",
+            side_effect=[
+                (path_prop_conflicted, schemas_1),
+                (path_prop, schemas_2),
+                (query_prop, schemas_3),
+            ],
+        )
+        path_conflicted_schema = mocker.MagicMock()
+        path_schema = mocker.MagicMock()
+        query_schema = mocker.MagicMock()
+
+        data = oai.Operation.construct(
+            parameters=[
+                oai.Parameter.construct(
+                    name=path_prop_conflicted.name, required=True, param_schema=path_conflicted_schema, param_in="path"
+                ),
+                oai.Parameter.construct(name=path_prop.name, required=True, param_schema=path_schema, param_in="path"),
+                oai.Parameter.construct(
+                    name=query_prop.name, required=False, param_schema=query_schema, param_in="query"
+                ),
+                oai.Reference.construct(),  # Should be ignored
+                oai.Parameter.construct(),  # Should be ignored
+            ]
+        )
+        initial_schemas = mocker.MagicMock()
+        config = MagicMock()
+
+        result = Endpoint._add_parameters(endpoint=endpoint, data=data, schemas=initial_schemas, config=config)[0]
+        assert isinstance(result, ParseError)
+        assert result.detail == "Parameters with same Python identifier `prop_name_path` detected"
+
     def test__add_parameters_happy(self, mocker):
         from openapi_python_client.parser.openapi import Endpoint
         from openapi_python_client.parser.properties import Property