Skip to content

Remove unnecessary package installations #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2024
Merged

Remove unnecessary package installations #2424

merged 2 commits into from
Apr 25, 2024

Conversation

@ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 15, 2024

Fixes #2423

@ocelotl ocelotl self-assigned this Apr 15, 2024
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 15, 2024
@ocelotl ocelotl force-pushed the issue_2423 branch 2 times, most recently from be5b603 to b72b5a2 Compare April 15, 2024 21:51
@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 15, 2024 •
edited
Loading

This PR adds more code to tox.ini but it now allows us to know exactly what test dependencies each package has. I want to move in a direction where the testing information for each package lives in each package and this is a step in that direction.

kafka, sio-pika and aio-pika do not need test-utils, so that test dependency has been removed from them.

@ocelotl ocelotl marked this pull request as ready for review April 15, 2024 22:04
@ocelotl ocelotl requested a review from a team April 15, 2024 22:04
tammy-baylis-swi
tammy-baylis-swi approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is good as a step in reorganization.

lzchen
lzchen reviewed Apr 17, 2024
View reviewed changes
@lzchen lzchen marked this pull request as draft April 18, 2024 16:39
@ocelotl ocelotl marked this pull request as ready for review April 25, 2024 15:58
@ocelotl ocelotl merged commit bd4a22a into open-telemetry:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen left review comments

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

@ocelotl ocelotl

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not install unnecessary packages

3 participants

@ocelotl @lzchen @tammy-baylis-swi