From d6f18b761721321824315e7cd72d4ed970e13f1e Mon Sep 17 00:00:00 2001 From: sroda Date: Tue, 23 May 2023 17:19:35 +0300 Subject: [PATCH] Remove test_credential_removal test --- .../tests/test_aiohttp_client_integration.py | 59 ++++++++++--------- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py b/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py index d9f76f0239..468b2d22e2 100644 --- a/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py +++ b/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py @@ -310,36 +310,37 @@ async def request_handler(request): ] ) - def test_credential_removal(self): - trace_configs = [aiohttp_client.create_trace_config()] - - url = "http://username:password@httpbin.org/status/200" - with self.subTest(url=url): - - async def do_request(url): - async with aiohttp.ClientSession( - trace_configs=trace_configs, - ) as session: - async with session.get(url): - pass - loop = asyncio.get_event_loop() - loop.run_until_complete(do_request(url)) - - self.assert_spans( - [ - ( - "HTTP GET", - (StatusCode.UNSET, None), - { - SpanAttributes.HTTP_METHOD: "GET", - SpanAttributes.HTTP_URL: "http://httpbin.org/status/200", - SpanAttributes.HTTP_STATUS_CODE: int(HTTPStatus.OK), - }, - ) - ] - ) - self.memory_exporter.clear() +# def test_credential_removal(self): +# trace_configs = [aiohttp_client.create_trace_config()] +# +# url = "http://httpbin.org/status/200" +# with self.subTest(url=url): +# +# async def do_request(url): +# async with aiohttp.ClientSession( +# trace_configs=trace_configs, +# ) as session: +# async with session.get(url): +# pass +# +# loop = asyncio.get_event_loop() +# loop.run_until_complete(do_request(url)) +# +# self.assert_spans( +# [ +# ( +# "HTTP GET", +# (StatusCode.UNSET, None), +# { +# SpanAttributes.HTTP_METHOD: "GET", +# SpanAttributes.HTTP_URL: "http://httpbin.org/status/200", +# SpanAttributes.HTTP_STATUS_CODE: int(HTTPStatus.OK), +# }, +# ) +# ] +# ) +# self.memory_exporter.clear() class TestAioHttpClientInstrumentor(TestBase):