Metrics instrumentation starlette #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketmehta28
requested changes
Sep 14, 2022
instrumentation/opentelemetry-instrumentation-starlette/tests/test_starlette_instrumentation.py
Show resolved
Hide resolved
lzchen
reviewed
Sep 20, 2022
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Sep 20, 2022
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Sep 20, 2022
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Outdated
Show resolved
Hide resolved
…m/rahulmukherjee68/opentelemetry-python-contrib into metrics-instrumentation-starlette
rahulmukherjee68
requested review from
lzchen and
srikanthccv
and removed request for
lzchen,
sanketmehta28 and
srikanthccv
lzchen
reviewed
Sep 26, 2022
| app.user_middleware = [ | ||
| x | ||
| for x in app.user_middleware | ||
| if x.cls is not OpenTelemetryMiddleware |
Contributor
There was a problem hiding this comment.
Should we do not isinstance() here?
lzchen
approved these changes
Sep 26, 2022
rahulmukherjee68
requested review from
sanketmehta28 and
srikanthccv
and removed request for
srikanthccv
sanketmehta28
approved these changes
Sep 27, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1146
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: