Adding multiple db connections support for django-instrumentation's sqlcommenter #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thiyagu55
changed the title
…on' into django-sqlcommenter-multiconection
Contributor
Author
|
@srikanthccv for your notice |
srikanthccv
approved these changes
Jul 11, 2022
Member
srikanthccv
left a comment
srikanthccv
left a comment
There was a problem hiding this comment.
LGTM, Please make the sqlcommenter specific utils private.
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Outdated
Show resolved
Hide resolved
…on' into django-sqlcommenter-multiconection
srikanthccv
reviewed
Jul 13, 2022
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
Contributor
|
@srikanthccv Please mark it as approved after the requested changes are in to avoid accidental merging. |
srikanthccv
suggested changes
Jul 13, 2022
Member
srikanthccv
left a comment
srikanthccv
left a comment
There was a problem hiding this comment.
blocking to prevent accidental merge. @Thiyagu55 please make the functions private since they are not user facing.
…on' into django-sqlcommenter-multiconection
srikanthccv
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple DB Connection support for sqlcommenter django-instrumetation
Opentelemetry-instrumentation-django's sqlcommenter will now be able to support multiple database connections.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit test has been added named test_multiple_connection_support
Checklist: