End span on exception or other premature exits

siminn-arnorgj · siminn-arnorgj · commit bf8919a19767 · 2023-11-08T17:22:50.000Z
diff --git a/instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py b/instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
@@ -630,6 +630,8 @@ async def __call__(self, scope, receive, send):
                         )
             if token:
                 context.detach(token)
+            if span.is_recording():
+                span.end()
 
     # pylint: enable=too-many-branches
 

Original file line number	Diff line number	Diff line change
`@@ -630,6 +630,8 @@ async def __call__(self, scope, receive, send):`
`630`	`630`	`)`
`631`	`631`	`if token:`
`632`	`632`	`context.detach(token)`
	`633`	`+ if span.is_recording():`
	`634`	`+ span.end()`
`633`	`635`
`634`	`636`	`# pylint: enable=too-many-branches`
`635`	`637`