Skip to content

Commit 30d25e9

Browse files
committed
added RPC system as enum
1 parent 62e0a31 commit 30d25e9

File tree

1 file changed

+3
-3
lines changed
  • instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc

1 file changed

+3
-3
lines changed

instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
from opentelemetry import trace
3030
from opentelemetry.context import attach, detach
3131
from opentelemetry.propagate import extract
32-
from opentelemetry.semconv.trace import SpanAttributes
32+
from opentelemetry.semconv.trace import RpcSystemValues, SpanAttributes
3333
from opentelemetry.trace.status import Status, StatusCode
3434

3535
logger = logging.getLogger(__name__)
@@ -206,7 +206,7 @@ def _start_span(
206206

207207
# standard attributes
208208
attributes = {
209-
SpanAttributes.RPC_SYSTEM: "grpc",
209+
SpanAttributes.RPC_SYSTEM: RpcSystemValues.GRPC.value,
210210
SpanAttributes.RPC_GRPC_STATUS_CODE: grpc.StatusCode.OK.value[0],
211211
}
212212

@@ -217,8 +217,8 @@ def _start_span(
217217
)
218218
attributes.update(
219219
{
220-
SpanAttributes.RPC_METHOD: method,
221220
SpanAttributes.RPC_SERVICE: service,
221+
SpanAttributes.RPC_METHOD: method,
222222
}
223223
)
224224

0 commit comments

Comments
 (0)