libnbc wrong answer (DI) fix for reduce_scatter #9606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the `count x dt_extent` is greater than INT_MAX then this will overflow the `offset` variable used to offset the buffer. The result was that the offset overflowed becoming negative causing the reduction to be performed in the incorrect memory location producing a wrong answer in the resulting buffers. * By preserving this value as a size_t we avoid the int overflow at the root of the problem. Signed-off-by: Joshua Hursey <[email protected]>
gpaulsen
approved these changes
Nov 1, 2021
Member
Author
|
Cherry picked to release branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count x dt_extentis greater than INT_MAX then thiswill overflow the
offsetvariable used to offset the buffer.The result was that the offset overflowed becoming negative
causing the reduction to be performed in the incorrect memory
location producing a wrong answer in the resulting buffers.
at the root of the problem.