Skip to content

Incorrect communication to client proc #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhc54 opened this issue Dec 16, 2017 · 7 comments
Closed

Incorrect communication to client proc #4629

rhc54 opened this issue Dec 16, 2017 · 7 comments

Comments

@rhc54
Copy link
Contributor

rhc54 commented Dec 16, 2017

Strictly in the v2.x series. The daemon immediately attempts to send a message to its lowest-ranked child. The child process is required to initiate communications and will connect back to the daemon when ready. The unexpected message results in a SIGPIPE as the child hasn't yet setup a connection and causes the pipe to fail when two simultaneous connections are in progress.

If we are not running under a debugger, then the daemon traps the SIGPIPE and ignores it. However, when under a debugger, the debugger traps the SIGPIPE and reacts to it, causing the entire procedure to potentially collapse. Unfortunately, this specifically impacts a particular debugger vendor.

@rhc54 rhc54 added this to the v2.1.3 milestone Dec 16, 2017
@rhc54 rhc54 self-assigned this Dec 16, 2017
@rhc54
Copy link
Contributor Author

rhc54 commented Dec 16, 2017

@dirk-schubert-arm (Dirk Schubert, DDT developer) I have shifted this problem from #3660

@ghost
Copy link

ghost commented Jan 3, 2018

Sorry for the late reply, I was on holiday. @xavier1arm has applied your fix in #4630 and can confirm it works. Thanks @rhc54. Is there anything I can help with to move #4630 forward. I feel not familiar enough with the code base to do the review, but on the other hand it's just a small and local change.

@rhc54
Copy link
Contributor Author

rhc54 commented Jan 3, 2018

Thanks for the update. I think we are stuck until @jsquyres returns from vacation, but the release isn't going anywhere until then anyway.

@hppritcha
Copy link
Member

merged fix #4630 into v2.x. closing this issue.

@jsquyres
Copy link
Member

jsquyres commented Jan 3, 2018

@rhc54 Is this a request that I test this (on v2.1.x) under DDT on my cluster?

If so, I can confirm that with the head of each of the following branches as of 3 Jan 2018:

  1. 2.0.x: DDT attachment works
  2. 2.1.x: DDT attachment works
  3. 3.0.x: DDT attachment works
  4. 3.1.x: DDT attachment works

@jsquyres
Copy link
Member

jsquyres commented Jan 3, 2018

I neglected to mention -- I tested with DDT Allinea Forge v7.0.2

@rhc54
Copy link
Contributor Author

rhc54 commented Jan 3, 2018

Sorry - wasn't necessary as Allinea as already confirmed it works 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants