coll/base: only retain datatypes/op if the request has not yet completed

a non blocking collective might return ompi_request_null, so we should not
retain anything in that case.

Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit 63d3ccd)

Author: ggouaillardet

ompi/mca/coll/base/coll_base_util.c

@@ -139,6 +139,9 @@ int ompi_coll_base_retain_op( ompi_request_t *req, ompi_op_t *op,
                               ompi_datatype_t *type) {
     ompi_coll_base_nbc_request_t *request = (ompi_coll_base_nbc_request_t *)req;
     bool retain = false;
+    if (REQUEST_COMPLETE(req)) {
+        return OMPI_SUCCESS;
+    }
     if (!ompi_op_is_intrinsic(op)) {
         OBJ_RETAIN(op);
         request->data.op.op = op;
@@ -175,6 +178,9 @@ int ompi_coll_base_retain_datatypes( ompi_request_t *req, ompi_datatype_t *stype
                                      ompi_datatype_t *rtype) {
     ompi_coll_base_nbc_request_t *request = (ompi_coll_base_nbc_request_t *)req;
     bool retain = false;
+    if (REQUEST_COMPLETE(req)) {
+        return OMPI_SUCCESS;
+    }
     if (NULL != stype && !ompi_datatype_is_predefined(stype)) {
         OBJ_RETAIN(stype);
         request->data.types.stype = stype;
@@ -246,6 +252,9 @@ int ompi_coll_base_retain_datatypes_w( ompi_request_t *req,
     bool retain = false;
     ompi_communicator_t *comm = request->super.req_mpi_object.comm;
     int scount, rcount;
+    if (REQUEST_COMPLETE(req)) {
+        return OMPI_SUCCESS;
+    }
     if (OMPI_COMM_IS_TOPO(comm)) {
         (void)mca_topo_base_neighbor_count (comm, &rcount, &scount);
     } else {