Fix warning of no prototypes for removed functions.

When compiling the removed functions in v4.0.x we were
defining ENABLE_MPI1_COMPAT to 1 in each implementation file,
so we wouldn't have to port these implementations to
call newer MPI APIs.  Ironic, because that's exactly what
we're asking our user to do.

This however neglected providing the protypes for these
removed functions when NOT configured with
--enable-mpi1-compatibility

This commit changes these removed functions to hardcode
OMPI_OMIT_MPI1_COMPAT_DECLS to 0 instead before including
the mpi header, so these functions will have full prototypes.

Signed-off-by: Geoffrey Paulsen <[email protected]>

Author: gpaulsen

ompi/mpi/c/address.c

@@ -27,10 +27,10 @@
  * with --enable-mpi1-compatibility.
  *
  * To prevent having to port these implementations of removed functions
- * to the newer MPI calls, we are defining ENABLE_MPI1_COMPAT to 1
- * before including the c bindings.
+ * to the newer MPI calls, we are defining OMPI_OMIT_MPI1_COMPAT_DECLS
+ * to 0 before including the c bindings.
  */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/errhandler_create.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/communicator/communicator.h"

ompi/mpi/c/errhandler_get.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/errhandler_set.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/type_extent.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/type_hindexed.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/type_hvector.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/type_lb.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"

ompi/mpi/c/type_struct.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 

ompi/mpi/c/type_ub.c

@@ -20,9 +20,10 @@
 
 #include "ompi_config.h"
 
-/* defining ENABLE_MPI1_COMPAT to 1 for removed implementations here.
+/* defining OMPI_OMIT_MPI1_COMPAT_DECLS to 0 for prototyping the
+ * removed implementations here.
  * see comments in address.c for more information. */
-#define ENABLE_MPI1_COMPAT 1
+#define OMPI_OMIT_MPI1_COMPAT_DECLS 0
 
 #include "ompi/mpi/c/bindings.h"
 #include "ompi/runtime/params.h"