Skip to content

Commit 22a2b99

Browse files
committed
fs/ufs and fs/lustre: remove erroneous return statement
an erroneous return statement has creeped in commit 1885d99 which leads to some processes not resetting stripe_size and stripe_count correctly. This can lead in 3.0.x to different fcoll modules being selected. The impact is not that dramatic on master and 3.1.x, but could lead to problems as well. Fixes #4745 Signed-off-by: Edgar Gabriel <[email protected]>
1 parent 88e26c6 commit 22a2b99

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

ompi/mca/fs/lustre/fs_lustre_file_open.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* University of Stuttgart. All rights reserved.
1010
* Copyright (c) 2004-2005 The Regents of the University of California.
1111
* All rights reserved.
12-
* Copyright (c) 2008-2017 University of Houston. All rights reserved.
12+
* Copyright (c) 2008-2018 University of Houston. All rights reserved.
1313
* Copyright (c) 2015 Research Organization for Information Science
1414
* and Technology (RIST). All rights reserved.
1515
* Copyright (c) 2016-2017 IBM Corporation. All rights reserved.
@@ -192,7 +192,6 @@ mca_fs_lustre_file_open (struct ompi_communicator_t *comm,
192192
ret = MPI_ERR_OTHER;
193193
}
194194
}
195-
return ret;
196195
}
197196

198197

ompi/mca/fs/ufs/fs_ufs_file_open.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* University of Stuttgart. All rights reserved.
1010
* Copyright (c) 2004-2005 The Regents of the University of California.
1111
* All rights reserved.
12-
* Copyright (c) 2008-2017 University of Houston. All rights reserved.
12+
* Copyright (c) 2008-2018 University of Houston. All rights reserved.
1313
* Copyright (c) 2015-2017 Research Organization for Information Science
1414
* and Technology (RIST). All rights reserved.
1515
* Copyright (c) 2016-2017 IBM Corporation. All rights reserved.
@@ -157,7 +157,6 @@ mca_fs_ufs_file_open (struct ompi_communicator_t *comm,
157157
ret = MPI_ERR_OTHER;
158158
}
159159
}
160-
return ret;
161160
}
162161

163162
fh->f_stripe_size=0;

0 commit comments

Comments
 (0)