This repository was archived by the owner on Sep 30, 2022. It is now read-only.
osc/rdma: use correct endpoint for local state #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If atomics are not globally visible (cpu and nic atomics do not mix) then a btl endpoint must be used to access local ranks. To avoid issues that are caused by having the same region registered with multiple handles osc/rdma was updated to always use the handle for rank 0. There was a bug in the update that caused osc/rdma to continue using the local endpoint for accessing the state even though the pointer/handle are not valid for that endpoint. This commit fixes the bug. Fixes open-mpi/ompi#1241. (cherry picked from open-mpi/ompi@49d2f44) Signed-off-by: Nathan Hjelm <[email protected]>
|
This will fix nvidia MTT issues. Wait on merge until after master MTT has run tonight. |
|
Test PASSed. |
|
@sjeaugey please double check that open-mpi/ompi@49d2f44 cleared up problems on master. |
|
As mentioned in open-mpi/ompi#1319 this is ok. |
jsquyres
added a commit
that referenced
this pull request
Jan 26, 2016
osc/rdma: use correct endpoint for local state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If atomics are not globally visible (cpu and nic atomics do not mix)
then a btl endpoint must be used to access local ranks. To avoid
issues that are caused by having the same region registered with
multiple handles osc/rdma was updated to always use the handle for
rank 0. There was a bug in the update that caused osc/rdma to continue
using the local endpoint for accessing the state even though the
pointer/handle are not valid for that endpoint. This commit fixes the
bug.
Fixes open-mpi/ompi#1241.
(cherry picked from open-mpi/ompi@49d2f44)
:bot🏷️bug
:bot:milestone:v2.0.0
:bot:assign: @sjeaugey
Signed-off-by: Nathan Hjelm [email protected]