Skip to content

fix: inject env variables to all pod containers #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2024
Merged

fix: inject env variables to all pod containers #634

merged 1 commit into from
May 14, 2024

Conversation

@odubajDT
Copy link
Contributor

@odubajDT odubajDT commented May 8, 2024 •
edited
Loading

Part-of: #542

Changes

  • fixed small issue in flaginjector about adding env variables to all containers (not only flagd sidecar)
  • adapt flagdinjector tests to test the changed behavior + simplify them
  • polish webhook for future extension with in-process evaluation

@odubajDT odubajDT changed the title chore: simplify flagdinjector tests chore: refactor flagdinjector and mutating webhook May 8, 2024
@odubajDT odubajDT marked this pull request as ready for review May 8, 2024 12:09
@odubajDT odubajDT requested a review from a team May 8, 2024 12:09
bacherfl
bacherfl reviewed May 13, 2024
View reviewed changes
@odubajDT odubajDT changed the title chore: refactor flagdinjector and mutating webhook fix: inject env variables to all pod containers May 13, 2024
@odubajDT odubajDT force-pushed the refactoring-flaginjector branch from 77c3f8f to 75c92d6 Compare May 13, 2024 12:54
@toddbaert toddbaert requested review from bacherfl and toddbaert May 13, 2024 16:21
@odubajDT odubajDT merged commit b21378e into open-feature:main May 14, 2024
@github-actions github-actions bot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bacherfl bacherfl bacherfl approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odubajDT @bacherfl @toddbaert