Enable support to ONNX 1.15. #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
…rflow-onnx into support_onnx_1_15
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
Signed-off-by: Jay Zhang <[email protected]>
xiaowuhu
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ONNX 1.15 version, the helper.make_attribute() method doesn't allow to accept an empty list unless the value of attr_type is given as well. 'attr_type' is a new attribute introduced in ONNX 1.15.
In same cases, tf2onnx may add an empty list as an attribute to a newly created ONNX node. This fix will handle this situation in ONNX 1.15 and lower versions for compatibility.
Fix #2280