Skip to content

Commit 5ae8d0f

Browse files
committed
rescript: make playwright-core compile
1 parent 4a99fd3 commit 5ae8d0f

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

build/build.fs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,8 @@ module Test =
186186
"safe", !! "node_modules/@types/yargs/index.d.ts", [];
187187
"minimal", !! "node_modules/@types/vscode/index.d.ts", ["--readable-names"];
188188

189-
// #404: complex package which could break topological sorting
190-
"minimal", !! "node_modules/playwright-core/index.d.ts", [];
189+
// #404: package with mutually recursive files (requires --merge)
190+
"minimal", !! "node_modules/playwright-core/index.d.ts" ++ "node_modules/playwright-core/types/*.d.ts", ["--merge"];
191191
]
192192

193193
for preset, package, additionalOptions in packages do
@@ -196,6 +196,15 @@ module Test =
196196
$"--preset {preset}"; $"-o {outputDir}"] @ additionalOptions)
197197
package
198198

199+
// patches for playwright-core
200+
Shell.replaceInFiles [
201+
"Readable.t", "Readable.t<'t>"
202+
"URL.t", "NodeJs.Url.t"
203+
] [
204+
outputDir </> "playwright_core.resi"
205+
outputDir </> "playwright_core.res"
206+
]
207+
199208
let build () =
200209
Shell.mkdir srcGeneratedDir
201210
for file in outputDir |> Shell.copyRecursiveTo true srcGeneratedDir do

dist/res/src/ts2ocaml.res

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ type true_ = bool
2525
type false_ = bool
2626
type intrinsic = private string
2727
type object = Type.Classify.object
28+
module Object = { type t = object }
2829
type function = Type.Classify.function
30+
module Function = { type t = function }
2931

3032
module Union = {
3133
type container<+'cases>
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
type _svgElement<'a>
2+
type svgElement_like<'a> = Dom.element_like<_svgElement<'a>>
3+
type t = svgElement_like<Dom._baseClass>

0 commit comments

Comments
 (0)