Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Upgrade dependencies dry run - July 2021 #355

Closed
4 of 10 tasks
ghost opened this issue May 18, 2021 · 12 comments
Closed
4 of 10 tasks

Upgrade dependencies dry run - July 2021 #355

ghost opened this issue May 18, 2021 · 12 comments

Comments

@ghost
Copy link

ghost commented May 18, 2021

The purpose of this task is to shake out any failures when upgrading dependencies and reduce how many release notes need to be reviewed in October 2021.

  • Skim release notes since last global upgrade of dependencies, looking for any breaking changes impacting this site
  • On a branch, upgrade all dependencies to the latest versions, except for any dependencies that we are being more cautious with
  • On the same branch, apply any adjustments to code and configurations based on release note suggestions. Make note of each of these adjustments in the October 2021 upgrade issue.
  • Perform manual regression test using the testing guide
  • Create a follow-up task to finish this upgrade in October 2021

Skim release notes:

  • next-transpile-modules
  • next
  • tailwind/typography
  • autoprefixer
  • tailwindcss

Apply a time box of 2 days to this task.

@ghost ghost mentioned this issue May 18, 2021
5 tasks
@ghost
Copy link
Author

ghost commented May 18, 2021

  • Switch from bsc to new rescript cli wrapper as part of upgrading to >= 9.1.x
  • Switch to using .mjs suffix and update webpack configuration to recognize .mjs, if this approach becomes the established standard for expressing that a project is implemented using ESM. (There is an example of doing this in an old PR (ocaml/ocaml.org@78ff90c) as well as in the rescript-lang.org PR history around April 2021.)

@ghost
Copy link
Author

ghost commented May 18, 2021

  • Upgrade to nodejs 15, if it is the new LTS version in July.

@ghost
Copy link
Author

ghost commented May 18, 2021

  • Use the new JIT engine in tailwindcss.

This will be done in #385.

@ghost
Copy link
Author

ghost commented May 18, 2021

Let's implement a few unit tests for some of our bindings, so that we can upgrade dependency versions with fewer manual regression tests.

@ghost
Copy link
Author

ghost commented May 19, 2021

We may want to finish #298 before starting this issue, or we can postpone for a while longer until more of the universe including nextjs, has moved fully towards ESM.

@ghost
Copy link
Author

ghost commented May 20, 2021

If nextjs fully supports ESM by July, remove next-transpile-modules.

@ghost
Copy link
Author

ghost commented May 27, 2021

Here are some current warnings:

19:29:26.798 | warning " > @glennsl/[email protected]" has incorrect peer dependency "bs-platform@^5.0.4".
19:29:26.801 | warning " > [email protected]" has unmet peer dependency "postcss@^8.1.0".
19:29:26.801 | warning " > [email protected]" has unmet peer dependency "postcss@^8.0.9".
19:29:26.801 | warning "tailwindcss > [email protected]" has unmet peer dependency "postcss@^8.1.13".

The bs-json dependency has been fixed in the master branch of bs-json. It hasn't been published to npm yet.

@ghost
Copy link
Author

ghost commented Jun 3, 2021

  • Upgrade esy to 0.6.10 explicitly

@ghost
Copy link
Author

ghost commented Jun 3, 2021

  • Revert to using "dependencies" instead of "devDependencies" in package.json for most tools. (After reading more discussions online, I like the suggestion of having "dependencies" include all tools needed to build the site for npm packages that are building static sites, not just libraries that will be referenced at runtime in the packaged build.)

@ghost
Copy link
Author

ghost commented Jun 10, 2021

If we implemented backstop or Percyio, we could automatically merge upgrades to autoprefixer, tailwindcss, and tailwind/typography.

@ghost
Copy link
Author

ghost commented Jun 17, 2021

@ghost
Copy link
Author

ghost commented Jun 21, 2021

I think we are moving towards more frequent, ad-hoc upgrades of dependencies, so I will close this issue for now.

@ghost ghost closed this as completed Jun 21, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants