Skip to content

Upgrade to Sentry packages v7 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmulholland opened this issue Jul 12, 2022 · 13 comments · Fixed by #461
Closed

Upgrade to Sentry packages v7 #433

bmulholland opened this issue Jul 12, 2022 · 13 comments · Fixed by #461

Comments

@bmulholland
Copy link
Contributor

https://github.com/getsentry/sentry-javascript/releases/tag/7.0.0

@alexcroox
Copy link

Sentry blogged about the size reduction in v7, it would be great to have this updated so we can improve the perf of our Nuxt apps.

https://blog.sentry.io/2022/07/19/javascript-sdk-package-reduced/

@rchl is there a possibility of having Sentry as a peer dependancy so this module doesn't need to be re-published every time they make a release?

@rchl
Copy link
Member

rchl commented Jul 21, 2022

@rchl is there a possibility of having Sentry as a peer dependancy so this module doesn't need to be re-published every time they make a release?

npm (and yarn too, pretty sure) will update the @sentry/* depenencies within specified range when running npm update @nuxtjs/sentry so there is not really a need to make those into peer dependencies.

@bmulholland
Copy link
Contributor Author

The range specifies 6, so upgrading to 7 is not possible right now.

@rchl
Copy link
Member

rchl commented Jul 21, 2022

My answer was not in relation to updating to version 7 but only about upgrading to new patch/minor releases within the v6 range.

As far as upgrading to v7, this is a task on its own as it needs changes in the module and using peer dependencies wouldn't change anything in that regard.

@alexcroox
Copy link

good to know about running npm update for minor bumps, thanks

@LegendSebastiano-L
Copy link

any ETA on this? @sentry/tracing it's blocked to V6 because @nuxtjs/sentry still used V6 and not 7.

@glebv
Copy link

glebv commented Sep 29, 2022

Hi, our company is going to use sentry-module in production but it doesn't support v7 libs. sentry.io ui warns that our code uses old sdk. Could you share some estimates or insights about the migration? Should we expect on the soon migration?
Thanks a lot for your work!

@rchl
Copy link
Member

rchl commented Sep 30, 2022

Not making any promises due to being short on time.

Technically there should be no issues with using v6. We are doing that at my company and as long as it works fine it's not a priority to update.

@glebv
Copy link

glebv commented Sep 30, 2022

@rchl thanks for your answer. Got it.

@vedmant
Copy link

vedmant commented Oct 16, 2022

I'm currently optimizing my nuxt app for google page speed tests and sentry code is quite a large piece of code. Upgrading to version 7 would be really helpful. Otherwise looks like I need to copy paste plugins and use sentry package directly.

@bmulholland
Copy link
Contributor Author

@rchl Do you have time to post a short description of what would be needed to make the upgrade happen? That way, maybe someone for whom it's a higher priority could make an attempt.

@rchl
Copy link
Member

rchl commented Oct 17, 2022

The task would be to adapt the module so that it's compatible with the new SDK, paying attention to all breaking changes. Not much else to it, I think.

#417 has some hints and even code to get this started.

@bmulholland
Copy link
Contributor Author

@vedmant maybe doing that work would be less work overall than the plugin copying you are considering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants