This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Add annotation for empty and emtpy_like #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
person142
reviewed
Jun 4, 2020
There was a problem hiding this comment.
Thanks @unnonouno! Just one thing about ndarray[int] where the existing code leads one astray.
numpy-stubs/__init__.pyi
Outdated
| order: str = ..., | ||
| subok: bool = ..., | ||
| shape: Optional[_ShapeLike] = ..., | ||
| ) -> ndarray[int]: ... |
There was a problem hiding this comment.
Hm the ndarray[int] in ones_like is actually a mistake (we haven't made ndarray generic over dtype yet). Mind removing the [int] part from empty_like and (while we're here) ones_like?
There was a problem hiding this comment.
Oh, sorry. I'll fix both.
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
emptyandempty_likebased on the similar functiononesandones_like.