Skip to content

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Jan 27, 2022

i also brought the ci-workspaces.yml in sync with the other workflows, but accounting for the workspace related changes. that probably should've been a separate commit but i got a little carried away..

@nlf nlf requested a review from a team as a code owner January 27, 2022 22:53
@nlf nlf force-pushed the nlf/workaround-windows-npm-bug branch 20 times, most recently from ea04198 to d0884a1 Compare January 28, 2022 19:20
@nlf nlf force-pushed the nlf/workaround-windows-npm-bug branch from d0884a1 to ac22d90 Compare January 28, 2022 19:26
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but we should probably have @fritzy sign off just in case those workspace ci files used ./bin/npm-cli.js for a reason

Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no specific reason the workspaces ci was out of date. LGTM

@nlf nlf merged commit 194c434 into main Jan 31, 2022
@nlf nlf deleted the nlf/workaround-windows-npm-bug branch January 31, 2022 23:34
dr-js added a commit to dr-js/dr-dev that referenced this pull request Feb 9, 2022
dr-js added a commit to dr-js/dr-js that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants