update: don't attempt to update linked packages

Fixes: #11362
PR-URL: npm/npm#11584
Credit: @rhendric
Reviewed-By: @iarna

Author: rhendric

lib/outdated.js

@@ -139,7 +139,7 @@ function makePretty (p) {
   if (long) columns[5] = type
 
   if (npm.color) {
-    columns[0] = color[has === want ? 'yellow' : 'red'](columns[0]) // dep
+    columns[0] = color[has === want || want === 'linked' ? 'yellow' : 'red'](columns[0]) // dep
     columns[2] = color.green(columns[2]) // want
     columns[3] = color.magenta(columns[3]) // latest
     columns[4] = color.brightBlack(columns[4]) // dir

lib/update.js

@@ -36,7 +36,7 @@ function update (args, cb) {
           "because it's currently at the maximum version that matches its specified semver range"
         )
       }
-      return ww.current !== ww.wanted
+      return ww.current !== ww.wanted && ww.latest !== 'linked'
     })
     if (wanted.length === 0) return cb()
 

test/tap/update-symlink.js

@@ -0,0 +1,91 @@
+var fs = require('graceful-fs')
+var path = require('path')
+var osenv = require('osenv')
+var mkdirp = require('mkdirp')
+var mr = require('npm-registry-mock')
+var rimraf = require('rimraf')
+var test = require('tap').test
+
+var common = require('../common-tap.js')
+
+var pkg = path.resolve(__dirname, 'update-symlink')
+var originalLog
+
+var fakeRoot = path.join(__dirname, 'fakeRoot')
+var OPTS = {
+  env: {
+    'npm_config_prefix': fakeRoot
+  }
+}
+
+var jsonLocal = {
+  name: 'my-local-package',
+  description: 'fixture',
+  version: '1.0.0',
+  dependencies: {
+    'async': '*',
+    'underscore': '*'
+  }
+}
+
+test('setup', function (t) {
+  cleanup()
+  originalLog = console.log
+  mkdirp.sync(pkg)
+  common.npm(['install', '-g', '[email protected]'], OPTS, function (err, c, out) {
+    t.ifError(err, 'global install did not error')
+    process.chdir(pkg)
+    fs.writeFileSync(
+      path.join(pkg, 'package.json'),
+      JSON.stringify(jsonLocal, null, 2)
+    )
+    common.npm(['link', 'underscore'], OPTS, function (err, c, out) {
+      t.ifError(err, 'link did not error')
+      common.npm(['install', '[email protected]'], OPTS, function (err, c, out) {
+        t.ifError(err, 'local install did not error')
+        common.npm(['ls'], OPTS, function (err, c, out, stderr) {
+          t.ifError(err)
+          t.equal(c, 0)
+          t.equal(stderr, '', 'got expected stderr')
+          t.has(out, /async@0.2.9/, 'installed ok')
+          t.has(out, /underscore@1.3.1/, 'creates local link ok')
+          t.end()
+        })
+      })
+    })
+  })
+})
+
+test('when update is called linked packages should be excluded', function (t) {
+  console.log = function () {}
+  mr({ port: common.port }, function (er, s) {
+    common.npm(['update'], OPTS, function (err, c, out, stderr) {
+      t.ifError(err)
+      t.has(out, /async@1.5.2/, 'updated ok')
+      t.doesNotHave(stderr, /ERR!/, 'no errors in stderr')
+      s.close()
+      t.end()
+    })
+  })
+})
+
+test('cleanup', function (t) {
+  common.npm(['rm', 'underscore', 'async'], OPTS, function (err, code) {
+    t.ifError(err, 'npm removed the linked package without error')
+    t.equal(code, 0, 'cleanup in local ok')
+    process.chdir(osenv.tmpdir())
+    common.npm(['rm', '-g', 'underscore'], OPTS, function (err, code) {
+      t.ifError(err, 'npm removed the global package without error')
+      t.equal(code, 0, 'cleanup in global ok')
+
+      console.log = originalLog
+      cleanup()
+      t.end()
+    })
+  })
+})
+
+function cleanup () {
+  rimraf.sync(pkg)
+  rimraf.sync(fakeRoot)
+}