Skip to content

Commit ba8b1be

Browse files
committed
fix tests 2
1 parent f1ec841 commit ba8b1be

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

integrations/issue_test.go

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -356,18 +356,23 @@ func TestSearchIssues(t *testing.T) {
356356

357357
session := loginUser(t, "user2")
358358

359+
// as this API is used in the frontend, it uses UI page size
360+
expectedIssueCount := 15 // from the fixtures
361+
if expectedIssueCount > setting.UI.IssuePagingNum {
362+
expectedIssueCount = setting.UI.IssuePagingNum
363+
}
364+
359365
link, _ := url.Parse("/issues/search")
360366
req := NewRequest(t, "GET", link.String())
361367
resp := session.MakeRequest(t, req, http.StatusOK)
362368
var apiIssues []*api.Issue
363369
DecodeJSON(t, resp, &apiIssues)
364-
// as this API is used in the frontend, it uses UI page size
365-
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
370+
assert.Len(t, apiIssues, expectedIssueCount)
366371

367372
req = NewRequest(t, "GET", link.String())
368373
resp = session.MakeRequest(t, req, http.StatusOK)
369374
DecodeJSON(t, resp, &apiIssues)
370-
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
375+
assert.Len(t, apiIssues, expectedIssueCount)
371376

372377
since := "2000-01-01T00%3A50%3A01%2B00%3A00" // 946687801
373378
before := time.Unix(999307200, 0).Format(time.RFC3339)
@@ -451,6 +456,12 @@ func TestSearchIssues(t *testing.T) {
451456
func TestSearchIssuesWithLabels(t *testing.T) {
452457
defer prepareTestEnv(t)()
453458

459+
// as this API is used in the frontend, it uses UI page size
460+
expectedIssueCount := 15 // from the fixtures
461+
if expectedIssueCount > setting.UI.IssuePagingNum {
462+
expectedIssueCount = setting.UI.IssuePagingNum
463+
}
464+
454465
token := getUserToken(t, "user1")
455466

456467
link, _ := url.Parse("/api/v1/repos/issues/search?token=" + token)
@@ -459,7 +470,7 @@ func TestSearchIssuesWithLabels(t *testing.T) {
459470
var apiIssues []*api.Issue
460471
DecodeJSON(t, resp, &apiIssues)
461472

462-
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
473+
assert.Len(t, apiIssues, expectedIssueCount)
463474

464475
query := url.Values{
465476
"token": []string{token},
@@ -468,7 +479,7 @@ func TestSearchIssuesWithLabels(t *testing.T) {
468479
req = NewRequest(t, "GET", link.String())
469480
resp = MakeRequest(t, req, http.StatusOK)
470481
DecodeJSON(t, resp, &apiIssues)
471-
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
482+
assert.Len(t, apiIssues, expectedIssueCount)
472483

473484
query.Add("labels", "label1")
474485
link.RawQuery = query.Encode()

0 commit comments

Comments
 (0)