From fd6367a36bdfba66c5f075f74c0c2d1d83d13459 Mon Sep 17 00:00:00 2001 From: ghaiklor Date: Thu, 24 Mar 2016 20:45:43 +0200 Subject: [PATCH 1/2] doc: fix doc for Buffer.readInt32LE() Update example and signature for readInt32LE method. --- doc/api/buffer.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/buffer.markdown b/doc/api/buffer.markdown index dfa8ba3d8d8941..36204f76da2a68 100644 --- a/doc/api/buffer.markdown +++ b/doc/api/buffer.markdown @@ -1049,7 +1049,7 @@ buf.readInt16LE(1); ### buf.readInt32BE(offset[, noAssert]) ### buf.readInt32LE(offset[, noAssert]) -* `offset` {Number} `0 <= offset <= buf.length - 4` +* `offset` {Number} `0 <= offset < buf.length - 4` * `noAssert` {Boolean} Default: false * Return: {Number} @@ -1067,7 +1067,7 @@ const buf = Buffer.from([1,-2,3,4]); buf.readInt32BE(); // returns 33424132 -buf.readInt32LE(1); +buf.readInt32LE(); // returns 67370497 ``` From aa9bee9b746bf60ff860a539d1985d43c4d607cc Mon Sep 17 00:00:00 2001 From: ghaiklor Date: Thu, 24 Mar 2016 21:30:20 +0200 Subject: [PATCH 2/2] doc: Fix offset range in readInt32BE() --- doc/api/buffer.markdown | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/api/buffer.markdown b/doc/api/buffer.markdown index 36204f76da2a68..a2462e1bc4cb2f 100644 --- a/doc/api/buffer.markdown +++ b/doc/api/buffer.markdown @@ -1049,7 +1049,7 @@ buf.readInt16LE(1); ### buf.readInt32BE(offset[, noAssert]) ### buf.readInt32LE(offset[, noAssert]) -* `offset` {Number} `0 <= offset < buf.length - 4` +* `offset` {Number} `0 <= offset <= buf.length - 4` * `noAssert` {Boolean} Default: false * Return: {Number} @@ -1069,6 +1069,8 @@ buf.readInt32BE(); // returns 33424132 buf.readInt32LE(); // returns 67370497 +buf.readInt32LE(1); + // throws RangeError: Index out of range ``` ### buf.readIntBE(offset, byteLength[, noAssert])