From 77fc9e844fc4da85e1306f83ec081275ef0fb699 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 13 Mar 2025 23:31:54 +0100 Subject: [PATCH 1/3] doc: add review guidelines for collaborator nominations --- GOVERNANCE.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index f898396952a7d2..da774e536b376e 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -183,6 +183,27 @@ Collaborators might overlook someone with valuable contributions. In that case, the contributor may open an issue or contact a collaborator to request a nomination. +#### How to review a collaborator nomination + +A collaborator nomination can be reviewed in the same way you'd review a PR +adding a feature: + +- If you see the nomination as something positive to the project, say so! +- If you are neutral, or feel you don't know enough to have an informed opinion, + it's certainly OK to not interact with the nomination. +- If you think the nomination can be detrimental to the project, share your + concerns, ideally before the public nomination is opened, and avoid sharing + those concerns outside of the Collaborator discussion area. + Ideally, list what step(s) the nominee could take that would make you + approve their nomination. + +Our goal is to keep gate-keeping at a minimal, but it cannot be zero since being +a collaborator requires trust (collaborators can start CI jobs, use their veto, +push commits, etc.), so what's the minimal amount is subjective, and there will +be cases where collaborators disagree on whether a nomination should move +forward. In those case, refrain from opening the public nomination until all +concerns have been addressed. + ### Onboarding After the nomination passes, a TSC member onboards the new collaborator. See From e559da03ada2450ee779504a62f858b3164d9d9c Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 13 Mar 2025 23:56:31 +0100 Subject: [PATCH 2/3] fixup! doc: add review guidelines for collaborator nominations --- GOVERNANCE.md | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index da774e536b376e..89e9cf2c2ef00a 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -185,24 +185,31 @@ nomination. #### How to review a collaborator nomination -A collaborator nomination can be reviewed in the same way you'd review a PR +A collaborator nomination can be reviewed in the same way one would review a PR adding a feature: -- If you see the nomination as something positive to the project, say so! -- If you are neutral, or feel you don't know enough to have an informed opinion, +* If you see the nomination as something positive to the project, say so! +* If you are neutral, or feel you don't know enough to have an informed opinion, it's certainly OK to not interact with the nomination. -- If you think the nomination can be detrimental to the project, share your +* If you think the nomination can be detrimental to the project, share your concerns, ideally before the public nomination is opened, and avoid sharing those concerns outside of the Collaborator discussion area. Ideally, list what step(s) the nominee could take that would make you approve their nomination. + Given that there is no "Request for changes" feature in discussions and issues, + try to be explicit when your comment is expressing a blocking concern. + Similarly, once the blocking concern has been addressed, explicitly say so. Our goal is to keep gate-keeping at a minimal, but it cannot be zero since being a collaborator requires trust (collaborators can start CI jobs, use their veto, push commits, etc.), so what's the minimal amount is subjective, and there will be cases where collaborators disagree on whether a nomination should move -forward. In those case, refrain from opening the public nomination until all -concerns have been addressed. +forward. + +When concerns have been raised on the private discussion, refrain from opening +the public issue. If no one has explicitly blocked the nomination and you'd like +it to move forward, comment something like "If I don't hear any objections +before (some time), I will open the public issue". ### Onboarding From 9e30580f959e21fd9af01cb1368cdaa2a4efe195 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sat, 15 Mar 2025 14:14:35 +0100 Subject: [PATCH 3/3] fixup! fixup! doc: add review guidelines for collaborator nominations --- GOVERNANCE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 89e9cf2c2ef00a..2e323fb296a79e 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -191,9 +191,9 @@ adding a feature: * If you see the nomination as something positive to the project, say so! * If you are neutral, or feel you don't know enough to have an informed opinion, it's certainly OK to not interact with the nomination. -* If you think the nomination can be detrimental to the project, share your - concerns, ideally before the public nomination is opened, and avoid sharing - those concerns outside of the Collaborator discussion area. +* If you think the nomination was made too soon, or can be detrimental to the + project, share your concerns, ideally before the public nomination is opened, + and avoid sharing those concerns outside of the Collaborator discussion area. Ideally, list what step(s) the nominee could take that would make you approve their nomination. Given that there is no "Request for changes" feature in discussions and issues,