From 8bd1114343012c21ccc0638547494d032e7eb92a Mon Sep 17 00:00:00 2001 From: Kaylyn Bogle Date: Tue, 1 Dec 2015 16:03:58 -0800 Subject: [PATCH 1/3] Added native module build tool message at end of windows msi install --- tools/msvs/msi/NodeExitDialog.wxs | 41 +++++++++++++++++++++++++++++++ tools/msvs/msi/i18n/en-us.wxl | 2 ++ tools/msvs/msi/nodemsi.wixproj | 1 + tools/msvs/msi/product.wxs | 2 +- 4 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tools/msvs/msi/NodeExitDialog.wxs diff --git a/tools/msvs/msi/NodeExitDialog.wxs b/tools/msvs/msi/NodeExitDialog.wxs new file mode 100644 index 00000000000000..7ad472e1e74eba --- /dev/null +++ b/tools/msvs/msi/NodeExitDialog.wxs @@ -0,0 +1,41 @@ + + + + + + + + + + + + + + + + WIXUI_EXITDIALOGOPTIONALCHECKBOXTEXT AND NOT Installed + + + + + + + + + + + + + + \ No newline at end of file diff --git a/tools/msvs/msi/i18n/en-us.wxl b/tools/msvs/msi/i18n/en-us.wxl index fd23724b562990..f3f83a12406882 100644 --- a/tools/msvs/msi/i18n/en-us.wxl +++ b/tools/msvs/msi/i18n/en-us.wxl @@ -35,4 +35,6 @@ Node.js has been successfully installed. + + Some native modules may require additional build tools to be installed. See the Windows Native Development Guide]]> for more information. diff --git a/tools/msvs/msi/nodemsi.wixproj b/tools/msvs/msi/nodemsi.wixproj index 70ffec50bcc8e4..568fcde488d56b 100644 --- a/tools/msvs/msi/nodemsi.wixproj +++ b/tools/msvs/msi/nodemsi.wixproj @@ -39,6 +39,7 @@ + npm.wxs diff --git a/tools/msvs/msi/product.wxs b/tools/msvs/msi/product.wxs index bdda1a19c13e72..8192996f5834a9 100755 --- a/tools/msvs/msi/product.wxs +++ b/tools/msvs/msi/product.wxs @@ -336,7 +336,7 @@ 1 1 1 - 1 + 1 NOT Installed OR WixUI_InstallMode = "Change" Installed AND NOT PATCH Installed AND PATCH From 9bd51993164b41111c2e40a06211efd77e52a68c Mon Sep 17 00:00:00 2001 From: Kaylyn Bogle Date: Tue, 12 Jan 2016 17:35:27 -0800 Subject: [PATCH 2/3] Updated URI to point to new Windows Environment page Added German translation --- tools/msvs/msi/i18n/de-de.wxl | 2 ++ tools/msvs/msi/i18n/en-us.wxl | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/msvs/msi/i18n/de-de.wxl b/tools/msvs/msi/i18n/de-de.wxl index 432d1eeaace3fb..fcaee52a54a93b 100644 --- a/tools/msvs/msi/i18n/de-de.wxl +++ b/tools/msvs/msi/i18n/de-de.wxl @@ -35,4 +35,6 @@ Node.js wurde erfolgreich installiert. + + Einige native Module benötigen eventuell zusätzliche Build-Tools um installiert werden zu können. Weitere Informationen finden Sie im Windows Environment]]>. diff --git a/tools/msvs/msi/i18n/en-us.wxl b/tools/msvs/msi/i18n/en-us.wxl index f3f83a12406882..e932539286a77f 100644 --- a/tools/msvs/msi/i18n/en-us.wxl +++ b/tools/msvs/msi/i18n/en-us.wxl @@ -36,5 +36,5 @@ Node.js has been successfully installed. - Some native modules may require additional build tools to be installed. See the Windows Native Development Guide]]> for more information. + Some native modules may require additional build tools to be installed. See Windows Environment]]> for more information. From 412cf9a7fe680ca4d8ea57d61bc8e66dafd9364e Mon Sep 17 00:00:00 2001 From: Kaylyn Bogle Date: Wed, 13 Jan 2016 18:35:23 -0800 Subject: [PATCH 3/3] updated german translation --- tools/msvs/msi/i18n/de-de.wxl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/msvs/msi/i18n/de-de.wxl b/tools/msvs/msi/i18n/de-de.wxl index fcaee52a54a93b..17a77c57d4d504 100644 --- a/tools/msvs/msi/i18n/de-de.wxl +++ b/tools/msvs/msi/i18n/de-de.wxl @@ -36,5 +36,5 @@ Node.js wurde erfolgreich installiert. - Einige native Module benötigen eventuell zusätzliche Build-Tools um installiert werden zu können. Weitere Informationen finden Sie im Windows Environment]]>. + Einige native Module benötigen eventuell zusätzliche Build-Tools um installiert werden zu können. Weitere Informationen finden Sie unter Windows Environment]]>.