Skip to content

perf_hooks: fix PerformanceObserver gc crash #39550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

perf_hooks: fix PerformanceObserver gc crash #39550

wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Jul 27, 2021

Signed-off-by: James M Snell [email protected]
Fixes: #39548

@jasnell jasnell changed the title perf: fix PerformanceObserver gc crash perf_hooks: fix PerformanceObserver gc crash Jul 27, 2021
@jasnell jasnell force-pushed the fix-perfobserver-gc-crash branch from 6886f54 to 403f34b Compare July 27, 2021 17:08
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell jasnell mentioned this pull request Jul 27, 2021
Closed
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 27, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 28, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39317/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 1, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39399/

@legendecas legendecas added perf_hooks Issues and PRs related to the implementation of the Performance Timing API. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 2, 2021
@legendecas
Copy link
Member

legendecas commented Aug 2, 2021

Landed in afabd14

@legendecas legendecas closed this Aug 2, 2021
@legendecas legendecas removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 2, 2021
legendecas pushed a commit that referenced this pull request Aug 2, 2021
@jasnell @legendecas
perf_hooks: fix PerformanceObserver gc crash
afabd14 
Signed-off-by: James M Snell <[email protected]>
Fixes: #39548

PR-URL: #39550
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@jasnell @danielleadams
perf_hooks: fix PerformanceObserver gc crash
016b7ba 
Signed-off-by: James M Snell <[email protected]>
Fixes: #39548

PR-URL: #39550
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bengl bengl bengl approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PerformanceObserver 'gc' crash with multiple observers

5 participants

@jasnell @nodejs-github-bot @legendecas @bengl @targos