From d66b0003eb6743da31ae56c72870afa92b89b2fd Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 24 Jun 2020 09:41:49 -0400 Subject: [PATCH 1/4] meta: add N-API to codeowners coverage We have this guidance for contributing to N-API: https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md It makes sense to have one of the N-API team sign off on commits that changes N-API Signed-off-by: Michael Dawson --- .github/CODEOWNERS | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 6fb4f7dc493b6a..7ad15411ce31a4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -74,3 +74,8 @@ # ./lib/internal/modules/* @nodejs/modules # ./lib/internal/bootstrap/loaders.js @nodejs/modules # ./src/module_wrap* @nodejs/modules @nodejs/vm + +# N-API + +# ./src/node_api* @nodejs/n-api +# ./src/js_native_api* @nodejs/n-api From 30897f394ee04ebbb249de1e72c9f2f86bd79f64 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 24 Jun 2020 13:23:54 -0400 Subject: [PATCH 2/4] squash: address comments --- .github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7ad15411ce31a4..11c8d7f4641167 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -79,3 +79,5 @@ # ./src/node_api* @nodejs/n-api # ./src/js_native_api* @nodejs/n-api +# ./doc/guides/adding-new-napi-api.md +# ./doc/api/n-api.md From 0ab5c019dc21c0afea86f8d8bbc62817c7172e3c Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 2 Jul 2020 15:55:16 -0400 Subject: [PATCH 3/4] Update .github/CODEOWNERS Co-authored-by: Richard Lau --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 11c8d7f4641167..06ea662718af3e 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -79,5 +79,5 @@ # ./src/node_api* @nodejs/n-api # ./src/js_native_api* @nodejs/n-api -# ./doc/guides/adding-new-napi-api.md -# ./doc/api/n-api.md +# ./doc/guides/adding-new-napi-api.md @nodejs/n-api +# ./doc/api/n-api.md @nodejs/n-api From c6e280694917b3adc1810a927b12f0d84e9e75a0 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 3 Jul 2020 16:50:08 -0400 Subject: [PATCH 4/4] accept comments Co-authored-by: James M Snell --- .github/CODEOWNERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 06ea662718af3e..b9fca0dcf91044 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -77,7 +77,7 @@ # N-API -# ./src/node_api* @nodejs/n-api -# ./src/js_native_api* @nodejs/n-api -# ./doc/guides/adding-new-napi-api.md @nodejs/n-api -# ./doc/api/n-api.md @nodejs/n-api +# /src/node_api* @nodejs/n-api +# /src/js_native_api* @nodejs/n-api +# /doc/guides/adding-new-napi-api.md @nodejs/n-api +# /doc/api/n-api.md @nodejs/n-api