From fc16912f62187dc5deac2e78c05512bcb836410c Mon Sep 17 00:00:00 2001
From: Arseniy Maximov <localhost@kern0.ru>
Date: Thu, 16 Feb 2017 23:29:23 +0300
Subject: [PATCH] test: refactor test-http-response-splitting

* move repeated code to function
* remove unneeded `common.mustCall()` usage with function arguments that
  are not callbacks
* add error message checking
---
 test/parallel/test-http-response-splitting.js | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/parallel/test-http-response-splitting.js b/test/parallel/test-http-response-splitting.js
index f6c3a04064ec1c..e6927bc1e63f77 100644
--- a/test/parallel/test-http-response-splitting.js
+++ b/test/parallel/test-http-response-splitting.js
@@ -19,23 +19,23 @@ const y = 'foo⠊Set-Cookie: foo=bar';
 
 let count = 0;
 
+function test(res, code, header) {
+  assert.throws(() => {
+    res.writeHead(code, header);
+  }, /^TypeError: The header content contains invalid characters$/);
+}
+
 const server = http.createServer((req, res) => {
   switch (count++) {
     case 0:
       const loc = url.parse(req.url, true).query.lang;
-      assert.throws(common.mustCall(() => {
-        res.writeHead(302, {Location: `/foo?lang=${loc}`});
-      }));
+      test(res, 302, {Location: `/foo?lang=${loc}`});
       break;
     case 1:
-      assert.throws(common.mustCall(() => {
-        res.writeHead(200, {'foo': x});
-      }));
+      test(res, 200, {'foo': x});
       break;
     case 2:
-      assert.throws(common.mustCall(() => {
-        res.writeHead(200, {'foo': y});
-      }));
+      test(res, 200, {'foo': y});
       break;
     default:
       common.fail('should not get to here.');