From 2f5b9a486556abcde8b1342c822f61aa76157009 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Thu, 22 Dec 2016 10:31:36 -0800 Subject: [PATCH] src: describe what NODE_MODULE_VERSION is for Current comment described what to do with it when the ABI changes, but implied that node would load modules with newer ABI numbers, which it will not. --- src/node_version.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node_version.h b/src/node_version.h index 61b98b1d508f0d..daefafa8eb26d5 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -44,6 +44,9 @@ (minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION)) /** + * Node.js will refuse to load modules that weren't compiled against its own + * module ABI number, exposed as the process.versions.modules property. + * * When this version number is changed, node.js will refuse * to load older modules. This should be done whenever * an API is broken in the C++ side, including in v8 or