process: make execve's args argument optional

Align the code with the documentation and similar methods used to
execute os commands - the `args` argument should be optional, and if
omitted, treated as an empty array (`[]`).

Fixes: #58411
PR-URL: #58412
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>

Author: mureinik

lib/internal/process/per_thread.js

@@ -237,7 +237,7 @@ function wrapProcessMethods(binding) {
     return true;
   }
 
-  function execve(execPath, args, env) {
+  function execve(execPath, args = [], env) {
     emitExperimentalWarning('process.execve');
 
     const { isMainThread } = require('internal/worker');

node.gyp

@@ -1336,6 +1336,13 @@
         }],
       ]
     }, # overlapped-checker
+    {
+      'target_name': 'nop',
+      'type': 'executable',
+      'sources': [
+        'test/nop/nop.c',
+      ]
+    }, # nop
     {
       'target_name': 'node_js2c',
       'type': 'executable',

test/nop/nop.c

@@ -0,0 +1,3 @@
+int main(void) {
+  return 0;
+}

test/parallel/test-process-execve-no-args.js

@@ -0,0 +1,25 @@
+'use strict';
+
+const { skip, isWindows, isIBMi } = require('../common');
+const { fail } = require('assert');
+const { isMainThread } = require('worker_threads');
+const { dirname, join } = require('path');
+const { existsSync } = require('fs');
+
+if (!isMainThread) {
+  skip('process.execve is not available in Workers');
+} else if (isWindows || isIBMi) {
+  skip('process.execve is not available in Windows or IBM i');
+}
+
+// Get full path to the executable used for the test
+const executable = join(dirname(process.execPath), 'nop');
+
+// Sanity check that the binary exists
+if (!existsSync(executable)) {
+  skip(executable + ' binary is not available');
+}
+
+process.execve(executable);
+// If process.execve succeeds, this should never be executed.
+fail('process.execve failed');