Skip to content

Commit 5cccd8f

Browse files
targosrichardlau
authored andcommitted
build: work around bug in MSBuild v16.10.0
This allows to build Node.js at the (temporary) cost of longer build times. Refs: #38872 Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0 Refs: dotnet/msbuild#6465 Refs: dotnet/msbuild#6373 PR-URL: #38873 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
1 parent 984eeb7 commit 5cccd8f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

vcbuild.bat

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,8 @@ if "%target%"=="Build" (
364364
if defined cctest set target="Build"
365365
)
366366
if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"
367+
@rem TODO(targos): Remove next line after MSBuild 16.10.1 is released.
368+
if "%target%"=="node" set target="Build"
367369
if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"
368370
msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args%
369371
if errorlevel 1 (

0 commit comments

Comments
 (0)