Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Apr 19, 2018

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2018

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          19       19           
  Lines         708      708           
=======================================
  Hits          627      627           
  Misses         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8cf80...6b56f06. Read the comment docs.

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the change logs of updated dependencies this is not breaking any of our code

Copy link
Contributor

@priyank-p priyank-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung merged commit 040a3d4 into nodejs:master Apr 19, 2018
@targos targos deleted the update-deps branch April 19, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants