Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

uri-parser disallows valid characters in scheme? #312

Closed
vinniefalco opened this issue May 29, 2016 · 4 comments
Closed

uri-parser disallows valid characters in scheme? #312

vinniefalco opened this issue May 29, 2016 · 4 comments

Comments

@vinniefalco
Copy link
Contributor

From rfc3986:

scheme        = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )

However, parse_url_char uses this BNF:

scheme        = 1#ALPHA

See:
https://github.com/nodejs/http-parser/blob/master/http_parser.c#L515

Is this by design?
@vinniefalco vinniefalco changed the title uri-parser non-compliance with rfc3986? uri-parser disallows valid characters in scheme? May 29, 2016
@ploxiln
Copy link
Contributor

ploxiln commented Jun 24, 2016

dup of #275 (and addressed in #276)

@vinniefalco
Copy link
Contributor Author

Hmm... its fixed at the tip of master?

@ploxiln
Copy link
Contributor

ploxiln commented Jun 24, 2016

nope

@vinniefalco
Copy link
Contributor Author

Oh, I see, #276 simply hasn't been merged. I'll close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ploxiln @vinniefalco