Auto merge of #357 - arcnmx:exec-void, r=@posborne

Use Void in exec return type

Indicates that these methods cannot return successfully. This does introduce a new dependency; an empty enum could be used instead but then you would lose the convenience `unreachable` methods exposed by the `void` crate, and standardizing on one type, etc...

Author: homu

Cargo.toml

@@ -23,9 +23,10 @@ preadv_pwritev = []
 signalfd = []
 
 [dependencies]
-libc     = "0.2.8"
+libc = "0.2.8"
 bitflags = "0.4"
 cfg-if = "0.1.0"
+void = "1.0.2"
 
 [build-dependencies]
 rustc_version = "0.1.7"

src/lib.rs

@@ -15,6 +15,7 @@ extern crate bitflags;
 
 #[macro_use]
 extern crate cfg_if;
+extern crate void;
 
 #[cfg(test)]
 extern crate nix_test as nixtest;

src/unistd.rs

@@ -7,6 +7,7 @@ use libc::{self, c_char, c_void, c_int, c_uint, size_t, pid_t, off_t, uid_t, gid
 use std::mem;
 use std::ffi::CString;
 use std::os::unix::io::RawFd;
+use void::Void;
 
 #[cfg(any(target_os = "linux", target_os = "android"))]
 pub use self::linux::*;
@@ -130,7 +131,7 @@ fn to_exec_array(args: &[CString]) -> Vec<*const c_char> {
 }
 
 #[inline]
-pub fn execv(path: &CString, argv: &[CString]) -> Result<()> {
+pub fn execv(path: &CString, argv: &[CString]) -> Result<Void> {
     let args_p = to_exec_array(argv);
 
     unsafe {
@@ -141,7 +142,7 @@ pub fn execv(path: &CString, argv: &[CString]) -> Result<()> {
 }
 
 #[inline]
-pub fn execve(path: &CString, args: &[CString], env: &[CString]) -> Result<()> {
+pub fn execve(path: &CString, args: &[CString], env: &[CString]) -> Result<Void> {
     let args_p = to_exec_array(args);
     let env_p = to_exec_array(env);
 
@@ -153,7 +154,7 @@ pub fn execve(path: &CString, args: &[CString], env: &[CString]) -> Result<()> {
 }
 
 #[inline]
-pub fn execvp(filename: &CString, args: &[CString]) -> Result<()> {
+pub fn execvp(filename: &CString, args: &[CString]) -> Result<Void> {
     let args_p = to_exec_array(args);
 
     unsafe {