test_pkg_info fail

[hubutui]

I'm trying to compile the latest release, and here is the fail test log:

FAIL: Test fallback version is up-to-date
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/build/python-nibabel/src/nibabel/nibabel/tests/test_pkg_info.py", line 33, in test_fallback_version
    assert (
AssertionError: nibabel.info.VERSION does not match current tag information

The complete log: nibabel-build-log.txt

[effigies]

Yes, that test did not take into account going through a release-candidate phase.

nibabel/nibabel/tests/test_pkg_info.py

Lines 27 to 38 in 4f366d3

	def test_fallback_version():
	"""Test fallback version is up-to-date
	This should only fail if we fail to bump nibabel.info.VERSION immediately
	after release
	"""
	assert (
	# dev version should be larger than tag+commit-githash
	cmp_pkg_version(VERSION) >= 0 or
	# Allow VERSION bump to lag releases by one commit
	VERSION == nib.__version__ + 'dev'), \
	"nibabel.info.VERSION does not match current tag information"

Is your build system unable to disable or ignore particular failing tests? If this is a significant problem, we can release a 3.0.1.

[effigies]

Might as well ping @TheChymera @ashgillman @sanjayankur31 @yarikoptic regarding how this failure is affecting your build systems.

[yarikoptic]

Hypothesising based on the content here alone, so pardon me if I am wrong: Well I could disable/patch that test away, but if I get it right, probably test should detect if it is running in the already git exported source - there some .gitattributes (or whatever) exported variable : https://github.com/nipy/nibabel/blob/master/.gitattributes . Then test should just skip and not test possible packaging repo tags

[effigies]

Right, we should definitely fix it to work correctly by the next release, and would definitely appreciate your eyes on any proposed fix... I'm just wondering if any packagers can't work around for this release, forcing a quick fix.

[hubutui]

@effigies I can completely skip the check/test. Could we disable particular tests by specify pytest's args or options?

[effigies]

We use nosetests, not pytest yet.

To skip this test, just add -e test_fallback_version.

[hubutui]

@effigies Oh, it's a typo. I mean notests. And I could build nibabel for Arch Linux CN Repository now, and skip the test_fallback_version.

[effigies]

Great! Thanks for accommodating this hiccup. I'll keep this issue open until the actual test is fixed...