Skip to content

Commit 790c037

Browse files
committed
RF: openers._gzip_open does not bother checking whether it is given open file
handles because, when called by Opener.__init__, it will only ever get passed file names.
1 parent 67405b0 commit 790c037

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

nibabel/openers.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -67,26 +67,16 @@ def readinto(self, buf):
6767
return n_read
6868

6969

70-
def _gzip_open(fileish, mode='rb', compresslevel=9):
71-
72-
# is this a file? if not we assume it is a string
73-
is_file = hasattr(fileish, 'read') and hasattr(fileish, 'write')
74-
75-
# If we've been given a file object, we can't change its mode.
76-
if is_file and hasattr(fileish, 'mode'):
77-
mode = fileish.mode
70+
def _gzip_open(filename, mode='rb', compresslevel=9):
7871

7972
# use indexed_gzip if possible for faster read access
8073
if mode == 'rb' and HAVE_INDEXED_GZIP:
81-
if is_file:
82-
gzip_file = SafeIndexedGzipFile(fid=fileish)
83-
else:
84-
gzip_file = SafeIndexedGzipFile(filename=fileish)
74+
gzip_file = SafeIndexedGzipFile(filename)
8575

8676
# Fall-back to built-in GzipFile (wrapped with the BufferedGzipFile class
8777
# defined above)
8878
else:
89-
gzip_file = BufferedGzipFile(fileish, mode, compresslevel)
79+
gzip_file = BufferedGzipFile(filename, mode, compresslevel)
9080

9181
# Speedup for #209, for versions of python < 3.5. Open gzip files with
9282
# faster reads on large files using a larger read buffer. See

0 commit comments

Comments
 (0)