TEST: Clean up tests to avoid triggering warnings/exceptions

Author: effigies

nibabel/nifti1.py

@@ -910,17 +910,17 @@ def set_data_dtype(self, datatype):
         Traceback (most recent call last):
            ...
         HeaderDataError: data dtype "<type 'numpy.void'>" known but not supported
-        >>> hdr.set_data_dtype('int')
+        >>> hdr.set_data_dtype('int') #doctest: +IGNORE_EXCEPTION_DETAIL
         Traceback (most recent call last):
            ...
         ValueError: Invalid data type 'int'. Specify a sized integer, e.g., 'uint8' or numpy.int16.
-        >>> hdr.set_data_dtype(int)
+        >>> hdr.set_data_dtype(int) #doctest: +IGNORE_EXCEPTION_DETAIL
         Traceback (most recent call last):
            ...
         ValueError: Invalid data type 'int'. Specify a sized integer, e.g., 'uint8' or numpy.int16.
         >>> hdr.set_data_dtype('int64')
-        >>> hdr.get_data_dtype()
-        dtype('int64')
+        >>> hdr.get_data_dtype() == np.dtype('int64')
+        True
         """
         if not isinstance(datatype, np.dtype) and datatype in (int, "int"):
             raise ValueError(f"Invalid data type {datatype!r}. Specify a sized integer, "
@@ -1926,7 +1926,7 @@ def set_qform(self, affine, code=None, strip_shears=True, **kwargs):
 
         Examples
         --------
-        >>> data = np.arange(24).reshape((2,3,4))
+        >>> data = np.arange(24, dtype='f4').reshape((2,3,4))
         >>> aff = np.diag([2, 3, 4, 1])
         >>> img = Nifti1Pair(data, aff)
         >>> img.get_qform()
@@ -2009,7 +2009,7 @@ def set_sform(self, affine, code=None, **kwargs):
 
         Examples
         --------
-        >>> data = np.arange(24).reshape((2,3,4))
+        >>> data = np.arange(24, dtype='f4').reshape((2,3,4))
         >>> aff = np.diag([2, 3, 4, 1])
         >>> img = Nifti1Pair(data, aff)
         >>> img.get_sform()

nibabel/tests/test_analyze.py

@@ -290,8 +290,13 @@ def assert_set_dtype(dt_spec, np_dtype):
         # Test aliases to Python types
         assert_set_dtype(float, np.float64)  # float64 always supported
         np_sys_int = np.dtype(int).type  # int could be 32 or 64 bit
-        if np_sys_int in self.supported_np_types:  # no int64 for Analyze
+        if np_sys_int == np.int32:  # no int64 for Analyze
             assert_set_dtype(int, np_sys_int)
+        elif issubclass(self.header_class, Nifti1Header):
+            # We don't allow int aliases in Nifti
+            with pytest.raises(ValueError):
+                hdr = self.header_class()
+                hdr.set_data_dtype(int)
         hdr = self.header_class()
         for inp in all_unsupported_types:
             with pytest.raises(HeaderDataError):

nibabel/tests/test_nifti1.py

@@ -770,7 +770,7 @@ def test_none_qsform(self):
         img_klass = self.image_class
         hdr_klass = img_klass.header_class
         shape = (2, 3, 4)
-        data = np.arange(24).reshape(shape)
+        data = np.arange(24, dtype='f4').reshape((2, 3, 4))
         # With specified affine
         aff = from_matvec(euler2mat(0.1, 0.2, 0.3), [11, 12, 13])
         for hdr in (None, hdr_klass()):
@@ -1040,7 +1040,7 @@ def test_affines_init(self):
         # is some thoughts by Mark Jenkinson:
         # http://nifti.nimh.nih.gov/nifti-1/documentation/nifti1fields/nifti1fields_pages/qsform_brief_usage
         IC = self.image_class
-        arr = np.arange(24).reshape((2, 3, 4))
+        arr = np.arange(24, dtype='f4').reshape((2, 3, 4))
         aff = np.diag([2, 3, 4, 1])
         # Default is sform set, qform not set
         img = IC(arr, aff)
@@ -1073,7 +1073,7 @@ def test_affines_init(self):
 
     def test_read_no_extensions(self):
         IC = self.image_class
-        arr = np.arange(24).reshape((2, 3, 4))
+        arr = np.arange(24, dtype='f4').reshape((2, 3, 4))
         img = IC(arr, np.eye(4))
         assert len(img.header.extensions) == 0
         img_rt = bytesio_round_trip(img)
@@ -1110,7 +1110,7 @@ class TestNifti1Image(TestNifti1Pair):
     def test_offset_errors(self):
         # Test that explicit offset too low raises error
         IC = self.image_class
-        arr = np.arange(24).reshape((2, 3, 4))
+        arr = np.arange(24, dtype='f4').reshape((2, 3, 4))
         img = IC(arr, np.eye(4))
         assert img.header.get_data_offset() == 0
         # Saving with zero offset is OK
@@ -1365,7 +1365,7 @@ def test_loadsave_cycle(self):
     def test_load(self):
         # test module level load.  We try to load a nii and an .img and a .hdr
         # and expect to get a nifti back of single or pair type
-        arr = np.arange(24).reshape((2, 3, 4))
+        arr = np.arange(24, dtype='f4').reshape((2, 3, 4))
         aff = np.diag([2, 3, 4, 1])
         simg = self.single_class(arr, aff)
         pimg = self.pair_class(arr, aff)
@@ -1439,7 +1439,7 @@ def test_rt_bias(self):
 
     def test_reoriented_dim_info(self):
         # Check that dim_info is reoriented correctly
-        arr = np.arange(24).reshape((2, 3, 4))
+        arr = np.arange(24, dtype='f4').reshape((2, 3, 4))
         # Start as RAS
         aff = np.diag([2, 3, 4, 1])
         simg = self.single_class(arr, aff)