From 60b7cab5b0251467ed6268b30e6bb4ba1a51bad3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niklas=20Hamb=C3=BCchen?= <mail@nh2.me>
Date: Mon, 8 Jun 2020 16:19:58 +0200
Subject: [PATCH] survey: Override ICU to have static libs

---
 survey/default.nix | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/survey/default.nix b/survey/default.nix
index 828beaa..f629548 100644
--- a/survey/default.nix
+++ b/survey/default.nix
@@ -661,6 +661,18 @@ let
     SDL2_image = previous.SDL2_image.overrideAttrs (old: { dontDisableStatic = true; });
     SDL2_mixer = previous.SDL2_mixer.overrideAttrs (old: { dontDisableStatic = true; });
 
+    # For icu, `dontDisableStatic` is not enough. We need explicit `--enable-static`.
+    # See https://github.com/unicode-org/icu/blob/0735ea8c6f6a0efa258db1f047edc63a43c6aafa/icu4c/source/configure.ac#L289-L299
+    # Also potentially concerning: http://userguide.icu-project.org/packaging
+    # > Users of your ICU must compile with -DU_STATIC_IMPLEMENTATION.
+    # TODO: Override ALL icu derivations, not just icu64.
+    icu64 = previous.icu64.overrideAttrs (old: {
+      dontDisableStatic = true;
+      configureFlags = (old.configureFlags or []) ++ [
+        "--enable-static"
+      ];
+    });
+
     libjpeg = previous.libjpeg.override (old: { enableStatic = true; });
     libjpeg_turbo = previous.libjpeg_turbo.override (old: { enableStatic = true; });