Skip to content

Commit 217a812

Browse files
committed
survey: Only skip stripping .a files, not executables
1 parent 9ba2931 commit 217a812

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

survey/default.nix

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -970,12 +970,23 @@ let
970970
# ])
971971
];
972972

973+
# Note [Slow stripping]:
973974
# There is currently a 300x `strip` performance regression in
974975
# `binutils`, making some strips take 5 minutes instead of 1 second.
975-
# Disable stripping until it's solved:
976+
# Disable stripping of libraries (`.a` files) until it's solved:
976977
# https://github.com/NixOS/nixpkgs/issues/129467
977978
# https://sourceware.org/bugzilla/show_bug.cgi?id=28058
978-
dontStrip = true;
979+
# We continue to strip executables because they don't seem to
980+
# be affected by the regression.
981+
#
982+
# There is also the consideration to keep `dontStrip = true;` the default,
983+
# so that people can decide at the very end whether they prefer small
984+
# executable sizes, or increased debuggability by keeping debug symbols.
985+
# However, until the `-g` issue
986+
# https://gitlab.haskell.org/ghc/ghc/-/issues/15960
987+
# is figured out, it may be best to not enable `-g`, and thus
988+
# not-stripping isn't as useful.
989+
configureFlags = (attrs.configureFlags or []) ++ [ "--disable-library-stripping" ];
979990
});
980991

981992
# Note:

0 commit comments

Comments
 (0)