WIP

Author: fantix

Makefile

@@ -3,18 +3,19 @@
 
 PYTHON ?= python3
 ROOT = $(dir $(realpath $(firstword $(MAKEFILE_LIST))))
-
+UV := $(shell command -v uv 2> /dev/null)
+ifdef UV
+	PYTHON := uv run
+	PIP := uv pip
+else
+	PIP := pip
+endif
 
 compile:
-	python3 setup.py build_ext --inplace
-
-
-release: compile test
-	python3 setup.py sdist upload
-
+	$(PIP) install -e .
 
 test: compile
-	python3 -m unittest -v
+	$(PYTHON) -m unittest -v
 
 clean:
 	find $(ROOT)/httptools/parser -name '*.c' | xargs rm -f
@@ -23,7 +24,3 @@ clean:
 distclean: clean
 	git --git-dir="$(ROOT)/vendor/http-parser/.git" clean -dfx
 	git --git-dir="$(ROOT)/vendor/llhttp/.git" clean -dfx
-
-
-testinstalled:
-	cd /tmp && $(PYTHON) $(ROOT)/tests/__init__.py

README.md

@@ -99,9 +99,7 @@ def parse_url(url: bytes):
 
 3. Activate the environment with `source envname/bin/activate`
 
-4. Install development requirements with `pip install -e .[test]`
-
-5. Run `make` and `make test`.
+4. Run `make` and `make test`.
 
 
 # License

_custom_build/backend.py

@@ -0,0 +1,44 @@
+# https://setuptools.pypa.io/en/latest/build_meta.html#dynamic-build-dependencies-and-other-build-meta-tweaks
+
+from setuptools import build_meta as _orig
+from setuptools.build_meta import *  # noqa
+
+
+def _strtobool(val: str) -> bool:
+    val = val.lower()
+    if val in ('y', 'yes', 't', 'true', 'on', '1'):
+        return True
+    elif val in ('n', 'no', 'f', 'false', 'off', '0'):
+        return False
+    else:
+        raise ValueError(f"invalid truth value {val!r}")
+
+
+def _get_build_requires(config_settings=None):
+    config_settings = config_settings or {}
+    need_cython = _strtobool(config_settings.get('--cython-always', '1'))
+    if not need_cython:
+        import pathlib
+
+        pkg_dir = pathlib.Path(__file__).parent / "httptools"
+        for cython_file in pkg_dir.glob("**/*.pyx"):
+            if not cython_file.with_suffix(".c").exists():
+                need_cython = True
+                break
+
+    build_requires = ["setuptools"]
+    if need_cython:
+        build_requires.append("cython>=3.1.0")
+    return build_requires
+
+
+def get_requires_for_build_sdist(config_settings=None):
+    return _get_build_requires(config_settings)
+
+
+def get_requires_for_build_wheel(config_settings=None):
+    return _get_build_requires(config_settings)
+
+
+def get_requires_for_build_editable(config_settings=None):
+    return _get_build_requires(config_settings)

pyproject.toml

@@ -1,10 +1,12 @@
 [build-system]
-build-backend = "setuptools.build_meta"
-requires = ["setuptools", "cython"]
+# Pr
+build-backend = "backend"
+backend-path = ["_custom_build"]
+requires = ["setuptools"]
 
 [project]
 name = "httptools"
-dynamic = ["version", "optional-dependencies"]
+dynamic = ["version"]
 classifiers = [
     "Intended Audience :: Developers",
     "Programming Language :: Python :: 3",
@@ -24,3 +26,6 @@ readme = "README.md"
 
 [project.urls]
 Homepage = "https://github.com/MagicStack/httptools"
+
+[project.optional-dependencies]
+test = []  # for backward compatibility

setup.py

@@ -1,34 +1,34 @@
 import sys
 
-from Cython.Build import cythonize
+import os.path
+import pathlib
 
-vi = sys.version_info
-if vi < (3, 8):
-    raise RuntimeError('httptools require Python 3.8 or greater')
-else:
-    import os.path
-    import pathlib
-
-    from setuptools import setup, Extension
-    from setuptools.command.build_ext import build_ext as build_ext
+from setuptools import setup, Extension
+from setuptools.command.build_ext import build_ext as build_ext
 
 
 CFLAGS = ['-O2']
 
 ROOT = pathlib.Path(__file__).parent
 
-CYTHON_DEPENDENCY = 'Cython>=3.1.0'
-
 
 class httptools_build_ext(build_ext):
     user_options = build_ext.user_options + [
+        ('cython-always', None,
+            'run cythonize() even if .c files are present'),
+        ('cython-annotate', None,
+            'Produce a colorized HTML version of the Cython source.'),
+        ('cython-directives=', None,
+            'Cythion compiler directives'),
         ('use-system-llhttp', None,
             'Use the system provided llhttp, instead of the bundled one'),
         ('use-system-http-parser', None,
             'Use the system provided http-parser, instead of the bundled one'),
     ]
 
     boolean_options = build_ext.boolean_options + [
+        'cython-always',
+        'cython-annotate',
         'use-system-llhttp',
         'use-system-http-parser',
     ]
@@ -43,6 +43,9 @@ def initialize_options(self):
         super().initialize_options()
         self.use_system_llhttp = False
         self.use_system_http_parser = False
+        self.cython_always = False
+        self.cython_annotate = None
+        self.cython_directives = None
 
     def finalize_options(self):
         # finalize_options() may be called multiple times on the
@@ -51,6 +54,43 @@ def finalize_options(self):
         if getattr(self, '_initialized', False):
             return
 
+        need_cythonize = self.cython_always
+        cfiles = {}
+
+        for extension in self.distribution.ext_modules:
+            for i, sfile in enumerate(extension.sources):
+                if sfile.endswith('.pyx'):
+                    prefix, ext = os.path.splitext(sfile)
+                    cfile = prefix + '.c'
+
+                    if os.path.exists(cfile) and not self.cython_always:
+                        extension.sources[i] = cfile
+                    else:
+                        if os.path.exists(cfile):
+                            cfiles[cfile] = os.path.getmtime(cfile)
+                        else:
+                            cfiles[cfile] = 0
+                        need_cythonize = True
+
+        if need_cythonize:
+            from Cython.Build import cythonize
+
+            directives = {}
+            if self.cython_directives:
+                for directive in self.cython_directives.split(','):
+                    k, _, v = directive.partition('=')
+                    if v.lower() == 'false':
+                        v = False
+                    if v.lower() == 'true':
+                        v = True
+
+                    directives[k] = v
+
+            self.distribution.ext_modules[:] = cythonize(
+                self.distribution.ext_modules,
+                compiler_directives=directives,
+                annotate=self.cython_annotate)
+
         super().finalize_options()
 
         self._initialized = True
@@ -100,14 +140,6 @@ def build_extensions(self):
             'unable to read the version from httptools/_version.py')
 
 
-setup_requires = []
-
-if (not (ROOT / 'httptools' / 'parser' / 'parser.c').exists() or
-        '--cython-always' in sys.argv):
-    # No Cython output, require Cython to build.
-    setup_requires.append(CYTHON_DEPENDENCY)
-
-
 setup(
     version=VERSION,
     platforms=['macOS', 'POSIX', 'Windows'],
@@ -116,7 +148,7 @@ def build_extensions(self):
     cmdclass={
         'build_ext': httptools_build_ext,
     },
-    ext_modules=cythonize([
+    ext_modules=[
         Extension(
             "httptools.parser.parser",
             sources=[
@@ -131,14 +163,7 @@ def build_extensions(self):
             ],
             extra_compile_args=CFLAGS,
         ),
-    ]),
+    ],
     include_package_data=True,
     exclude_package_data={"": ["*.c", "*.h"]},
-    test_suite='tests.suite',
-    setup_requires=setup_requires,
-    extras_require={
-        'test': [
-            CYTHON_DEPENDENCY
-        ]
-    }
 )