Skip to content

Set supported kinds based on listener #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kate-osborn opened this issue May 30, 2023 · 0 comments · Fixed by #809
Closed

Set supported kinds based on listener #690

kate-osborn opened this issue May 30, 2023 · 0 comments · Fixed by #809
Assignees
@ciarams87
Labels
area/gateway/core Relates to all Core features of Gateway enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Milestone
v0.5.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented May 30, 2023 •
edited by mpstefan
Loading

SupportedKinds is the list indicating the Kinds supported by this listener. This MUST represent the kinds an implementation supports for that Listener configuration.

If kinds are specified in Spec that are not supported, they MUST NOT appear in this list and an implementation MUST set the “ResolvedRefs” condition to “False” with the “InvalidRouteKinds” reason. If both valid and invalid Route kinds are specified, the implementation MUST reference the valid Route kinds that have been specified.

Acceptance Criteria:

  • Conformance tests for GatewayInvalidRouteKind pass
@kate-osborn kate-osborn self-assigned this May 30, 2023
@mpstefan mpstefan added the tech-debt Short-term pain, long-term benefit label Jun 9, 2023
@ciarams87 ciarams87 mentioned this issue Jun 28, 2023
Merged
6 tasks
@ciarams87 ciarams87 added this to the v0.5.0 milestone Jun 28, 2023
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. enhancement New feature or request area/gateway/core Relates to all Core features of Gateway and removed tech-debt Short-term pain, long-term benefit labels Jun 28, 2023
@mpstefan mpstefan changed the title FIXME: Set supported kinds based on listener Set supported kinds based on listener Jun 28, 2023
@kate-osborn kate-osborn removed their assignment Jun 28, 2023
@ciarams87 ciarams87 self-assigned this Jun 29, 2023
@ciarams87 ciarams87 mentioned this issue Jul 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciarams87 ciarams87

Labels
area/gateway/core Relates to all Core features of Gateway enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Support SupportedKinds in ListenerStatus ciarams87/nginx-gateway-fabric
3 participants
@mpstefan @ciarams87 @kate-osborn