Skip to content

Support for tracing using OpenTelemetry #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjberman opened this issue Oct 19, 2023 · 3 comments
Closed

Support for tracing using OpenTelemetry #1166

sjberman opened this issue Oct 19, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@sjberman
Copy link
Collaborator

sjberman commented Oct 19, 2023

As a user of NGF
I want NGF to have the ability to generate and send traces
So that I can easily get tracing for all of my traffic to help debug my environment.

The CRD defined in #929 should be used as the configuration entrypoint for a user.

Question
Should the CRD be attached to the GatewayClass or the Gateway?: Answer: GatewayClass

Reference
Otel POC: https://github.com/ciarams87/nginx-gateway-fabric/tree/spike/try-otel

Acceptance Criteria

- Data plane CRD is initialized when NGF is installed
- CRD is watched for and handled if attached to our Gateway

  • When enabled, the NGINX otel module is utilized to generate traces.
  • Generated traces can be exported to a configurable endpoint.
  • All fields from otel_exporter directive are configurable by the user.
  • Documentation is created to explain this feature.
    - Enhancement proposal is updated to "Completed"

To be merged into the feat/data-plane-crd feature branch.

@sjberman sjberman added the enhancement New feature or request label Oct 19, 2023
@mpstefan mpstefan added this to the v1.1.0 milestone Oct 23, 2023
@mpstefan mpstefan added the blocked Blocked by other issue label Oct 31, 2023
@mpstefan
Copy link
Member

mpstefan commented Oct 31, 2023

Blocked by #929

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Oct 31, 2023
@ciarams87 ciarams87 removed the blocked Blocked by other issue label Nov 6, 2023
@ciarams87 ciarams87 self-assigned this Nov 6, 2023
@ciarams87
Copy link
Contributor

Blocked by #1261

@ciarams87 ciarams87 added the blocked Blocked by other issue label Nov 20, 2023
@ja20222 ja20222 added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Nov 20, 2023
@ja20222 ja20222 removed this from the v1.1.0 milestone Nov 20, 2023
@mpstefan mpstefan removed backlog Currently unprioritized work. May change with user feedback or as the product progresses. blocked Blocked by other issue labels Feb 6, 2024
@mpstefan mpstefan modified the milestones: v1.2.0, v2.0.0 Feb 6, 2024
@ciarams87 ciarams87 removed their assignment Feb 28, 2024
@mpstefan mpstefan removed refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Mar 11, 2024
@sjberman
Copy link
Collaborator Author

Closing in favor of new stories in the epic.

@sjberman sjberman closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants