Skip to content

Measure time to update statuses of resources in reconfig tests #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pleshakov opened this issue Oct 10, 2023 · 1 comment · Fixed by #1186
Closed

Measure time to update statuses of resources in reconfig tests #1127

pleshakov opened this issue Oct 10, 2023 · 1 comment · Fixed by #1186
Assignees
Labels
refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days tests Pull requests that update tests
Milestone

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Oct 10, 2023

Include measuring time it takes for NGF to update statuses of resources during a reconfiguration.

There are two main outputs of the NGF:

  • updated NGINX configuration with NGINX being reloaded (we check for that in reconfig test)
  • updated statuses (we don't)

Statuses tell users (CI/CD pipelines or humans) that resources have been successfully processed and applied, which is a trigger for them to take actions - for example, roll back in case of problems or proceed further in their steps in case of success.

Additionally, NGF cannot process any resource changes while it is update statuses, so if we have bugs there, they affect how quickly NGF responds to changes in a cluster.

Also note that if NGF leader (which updates statuses) processes cluster changes at much different speed than NFG follower, that could lead to configuration skews among NGF replicas.

Considering that, it is important to measure status updates.

Acceptance criteria:

  • In addition to measuring reload time, measure time it takes for NGF to update statuses of resources during a reconfiguration.
  • The reconfiguration tests are ran again and the results updated for 1.0
@ja20222 ja20222 added enhancement New feature or request tests Pull requests that update tests labels Oct 11, 2023
@ja20222 ja20222 added this to the v1.0.0 milestone Oct 11, 2023
@ja20222 ja20222 added the size/small Estimated to be completed within ~2 days label Oct 11, 2023
@kate-osborn kate-osborn added the blocked Blocked by other issue label Oct 11, 2023
@kate-osborn
Copy link
Contributor

kate-osborn commented Oct 11, 2023

Blocked by #1131

@kate-osborn kate-osborn removed enhancement New feature or request blocked Blocked by other issue labels Oct 11, 2023
@bjee19 bjee19 self-assigned this Oct 12, 2023
@mpstefan mpstefan added the blocked Blocked by other issue label Oct 18, 2023
@bjee19 bjee19 removed the blocked Blocked by other issue label Oct 19, 2023
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days tests Pull requests that update tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants