Skip to content

Commit f3c93e8

Browse files
committed
Revert router changes but add continue on error to workflow
1 parent 65f1658 commit f3c93e8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/nfr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ jobs:
146146

147147
- name: Create and setup Router
148148
working-directory: ./tests
149-
run: make create-gke-router
149+
run: make create-gke-router || true
150150

151151
- name: Run Tests
152152
working-directory: ./tests

tests/scripts/create-gke-router.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ gcloud compute routers create "${RESOURCE_NAME}" \
1111
gcloud compute routers nats create "${RESOURCE_NAME}" \
1212
--router-region "${GKE_CLUSTER_REGION}" \
1313
--router "${RESOURCE_NAME}" \
14-
--auto-allocate-nat-external-ips \
15-
--nat-custom-subnet-ip-ranges="default"
14+
--nat-all-subnet-ip-ranges \
15+
--auto-allocate-nat-external-ips

0 commit comments

Comments
 (0)