Correct header name validation (#1239)

Correct header name validation.

Problem: Header name validation was not being implemented by NGF thus any problems would be caught by nginx and would not be as visible.

Solution: NGF now validates header names and will show an error in the HTTPRoute status.

Author: bjee19

internal/mode/static/nginx/config/validation/http_njs_match.go

@@ -46,6 +46,10 @@ func (HTTPNJSMatchValidator) ValidatePathInMatch(path string) error {
 }
 
 func (HTTPNJSMatchValidator) ValidateHeaderNameInMatch(name string) error {
+	if err := k8svalidation.IsHTTPHeaderName(name); err != nil {
+		return errors.New(err[0])
+	}
+
 	return validateNJSHeaderPart(name)
 }
 

internal/mode/static/nginx/config/validation/http_njs_match_test.go

@@ -34,12 +34,18 @@ func TestValidateHeaderNameInMatch(t *testing.T) {
 		t,
 		validator.ValidateHeaderNameInMatch,
 		"header",
+		"version",
+		"version-2",
 	)
 	testInvalidValuesForSimpleValidator(
 		t,
 		validator.ValidateHeaderNameInMatch,
 		":",
 		"",
+		"version%!",
+		"version_2",
+		"hello$world",
+		"   ",
 	)
 }
 
@@ -50,12 +56,16 @@ func TestValidateHeaderValueInMatch(t *testing.T) {
 		t,
 		validator.ValidateHeaderValueInMatch,
 		"value",
+		"version%!",
+		"version-2",
 	)
 	testInvalidValuesForSimpleValidator(
 		t,
 		validator.ValidateHeaderValueInMatch,
 		":",
 		"",
+		"hello$world",
+		"   ",
 	)
 }